Project

General

Profile

Bug #12400

Opencl code of non local means does not produce the same result as sse and "normal" code

Added by rawfiner - 10 months ago. Updated 8 months ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
OpenCL
Target version:
Start date:
11/11/2018
Due date:
% Done:

100%

Estimated time:
Affected Version:
git master branch
System:
unknown
bitness:
64-bit
hardware architecture:
amd64/x86

Description

When processing an image with either denoise (non local means) or denoise (profiled) in non local means mode, the processed image is different if opencl is used.
There are differences in the result obtained in a lot of pixels of the image.
The differences are small for pixels in the center of the image, and the differences on the top, bottom, and sides can be much more visible.

In the attached images, I used a patch size of 0, patch radius of 20 (the effect is more visible when patch radius is big, but is here whatever the value of patch radius), and force of 4, on the image "degrade.jpg".
The image degrade_difference_.jpg shows the enhanced difference of the images from sse and opencl code.

degrade_cpu.jpg (537 KB) degrade_cpu.jpg rawfiner -, 11/11/2018 05:14 PM
degrade_gpu.jpg (533 KB) degrade_gpu.jpg rawfiner -, 11/11/2018 05:14 PM
degrade_difference_.jpg (539 KB) degrade_difference_.jpg rawfiner -, 11/11/2018 05:14 PM
degrade.jpg (275 KB) degrade.jpg rawfiner -, 11/11/2018 05:20 PM
gpu.jpg (131 KB) gpu.jpg rawfiner -, 01/05/2019 06:59 PM
cpu.jpg (116 KB) cpu.jpg rawfiner -, 01/05/2019 06:59 PM

Associated revisions

Revision 3a26980e (diff)
Added by rawfiner - 8 months ago

Bugfix for opencl of nlmeans (denoiseprofile)

Fixes #12400

History

#1 Updated by rawfiner - 10 months ago

I found a fix. I will open a pull request as soon as possible (I need to cleanup my code and to test it a bit more before that)

#3 Updated by Aurélien PIERRE 10 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

#4 Updated by Roman Lebedev 10 months ago

  • Target version set to 2.6.0

#5 Updated by rawfiner - 9 months ago

The issue is not fixed, the changes of the pull request made only the effect less easy to see...
See attached images. I have no idea of what may cause this :-/

#6 Updated by rawfiner - 9 months ago

By the way, the behavior is a bit different now, as borders are undersmoothed, wereas before they were oversmoothed

#7 Updated by rawfiner - 8 months ago

I have maybe found a fix. I will open a pull request soon, after more testing

#8 Updated by rawfiner - 8 months ago

  • % Done changed from 100 to 50
  • Status changed from Fixed to In Progress

#9 Updated by rawfiner - 8 months ago

  • Assignee set to rawfiner -

#10 Updated by rawfiner - 8 months ago

  • % Done changed from 50 to 100
  • Status changed from In Progress to Fixed

Also available in: Atom PDF

Go to top