high quality export
It seems the last commit in pixelpipe_hb.c broke export with high_quality on : I got a full magenta jpeg.
If I revert to gamma instead of colorout : it works again.
#5 Updated by jean-luc Le Corre 11 months ago
Here the link to the files (raw + xmp + jpeg without and with hq set to on) : https://www.dropbox.com/s/4di38odl9r6rol3/DSC01405.tar.xz?dl=0
I noticed that the called modules differs at the end of the export:
no HQ :
87,141387 [dev_pixelpipe] took 0,003 secs (0,000 CPU) processed `niveaux' on GPU, blended on GPU [export]
87,146483 [dev_pixelpipe] took 0,005 secs (0,001 CPU) processed `profil de couleur de sortie ' on GPU, blended on GPU [export]
87,164386 [dev_pixelpipe] took 0,018 secs (0,069 CPU) processed `gamma' on CPU, blended on CPU [export]
62,802617 [dev_pixelpipe] took 0,014 secs (0,037 CPU) processed `niveaux' on GPU, blended on GPU [export]
62,832292 [dev_pixelpipe] took 0,030 secs (0,025 CPU) processed `redimensionne à la taille finale' on GPU, blended on GPU [export]
62,851648 [dev_pixelpipe] took 0,019 secs (0,069 CPU) processed `gamma' on CPU, blended on CPU [export]
#9 Updated by jean-luc Le Corre 11 months ago
I had a look a the code :
The dt_dev_pixelpipe_process_no_gamma function in pixelpipe_hb.c is called in 2 cases :
HQ export and export in non 8bpp format => I tested with png 16 and jpeg 2000 : I also got artifacts (without HQ export) - see attached. With gamma module disabled no artifact. So I think the gamma module should stay disabled by that function.
For fun I tried to disable both gamma and colorout : I got a strange result - see attached.
- % Done changed from 70 to 100
- Status changed from Patch attached to Fixed
Applied in changeset darktable|7ef5a49e373ab4fb5b16ed31d3adc8946cc34ff1.