Project

General

Profile

Bug #12381

In the darkroom, string "sharpen" in module title is never localised

Added by Jean-Luc Coulon 3 months ago. Updated 3 months ago.

Status:
Fixed
Priority:
Critical
Assignee:
Category:
Darkroom
Target version:
Start date:
10/28/2018
Due date:
% Done:

100%

Affected Version:
git master branch
System:
Debian
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi,

The string "sharpen" in the module title of the darkroom is never localised.
I've tested with the French (usual for me) and the Spanish locale.

I've done a bisect:
/usr/local/src/darktable/darktable-2.5.0/ git bisect bad
58a9aa3f68ed7cbfdff7a9ca7f6bd40241517a03 is the first bad commit
commit 58a9aa3f68ed7cbfdff7a9ca7f6bd40241517a03
Author: Pascal Obry <>
Date: Fri Oct 26 17:28:58 2018 +0200

Minor reformatting and style fixes.

:040000 040000 4cbc28483bfec06205b196abd264667ee3acb8ce 80cc02deab1c159917a4f16120bc55b55202d722 M src

Regards

Jean-Luc

tone-mapping.png (699 KB) Jean-Luc Coulon, 10/31/2018 09:24 PM

History

#1 Updated by Pascal Obry 3 months ago

Can't be this commit, but I confirm the issue. This is because I have fixed the context translation from:

_C("sharpen", "sharpen")

to what is used in others IOP:

_C("modulename", "sharpen")

But this does not work for this IOP! Don't know why, really strange.

#2 Updated by Pascal Obry 3 months ago

I've just pushed a fix. Can you test? Thanks.

#3 Updated by Pascal Obry 3 months ago

  • % Done changed from 0 to 10
  • Target version set to 2.6.0
  • Priority changed from Low to Critical
  • Assignee set to Pascal Obry
  • Status changed from New to Confirmed

#4 Updated by Pascal Obry 3 months ago

  • Status changed from Confirmed to Fixed
  • % Done changed from 10 to 100

Fixed now.

#5 Updated by Pascal Obry 3 months ago

And thanks for reporting.

#6 Updated by Jean-Luc Coulon 3 months ago

Pascal Obry wrote:

Fixed now.

Maybe :)
I've found "tone mapping" is no more in the po file (commented out):
grep 'tone mapping' fr.po
msgid "tone mapping method"
#~ msgid "tone mapping"

Jean-Luc

#7 Updated by Pascal Obry 3 months ago

Because it is not used. These are English message. Open fr.po and look, you'll see "tone mapping method" translated.

#8 Updated by Jean-Luc Coulon 3 months ago

Yes (it appears in the grep result I submited)
But see the attached screeshot

#9 Updated by Pascal Obry 3 months ago

I see, I forgot to fix one C++ file (tonemap.cc)! My mistake should be fixed now. Thanks.

Also available in: Atom PDF