Project

General

Profile

Bug #12255

Selecting a module through a keyboard shortcut collapses it

Added by P G 2 months ago.

Status:
Patch attached
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
07/08/2018
Due date:
% Done:

70%

Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Steps to reproduce:
1. Set keyboard shortcuts for 2 modules in two different groups (tabs)
2. Select module 1. It expands
3. Select module 2. Tab is changed and module 2 expands
4. Select module 1 again. Tab is changed but as module 1 was already expanded within its tab, it is collapsed.

NB: this was tested with option "darkroom/ui/single_module" enabled.

In the proposed patch, I removed the "all_other_closed" variable from method imageop.c::dt_iop_gui_set_expanded, which I think is not needed anymore, but as my knowledge of the darktable code is limited it would be good to review this more closely.

Also available in: Atom PDF