Project

General

Profile

Bug #12239

Darktable unable to process DNG converted from Panasonic LX1 raw

Added by me here about 1 year ago. Updated about 1 year ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
-
Target version:
Start date:
06/19/2018
Due date:
% Done:

100%

Estimated time:
Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

DT shows only skull and can't open DNG file converted from RAW of LX1. Error: Can't read WB.

2018-04-04-160526.dng (9.21 MB) 2018-04-04-160526.dng me here, 06/19/2018 10:01 PM
P1080763.RAW (16.1 MB) P1080763.RAW me here, 06/19/2018 10:20 PM
P1080763.dng (7.83 MB) P1080763.dng me here, 06/19/2018 10:22 PM

Associated revisions

Revision 68348c2f (diff)
Added by Roman Lebedev about 1 year ago

RawSpeed submodule update: LJpegDecompressor: support degenerate raws with width % 2 != 0

This is needed e.g for DNG's converted from Panasonic DMC-LX1 raws.
I have no words. What were they (Adobe) thinking.

They discard padding columns, that were garbage,
and end up with such an odd raw, where the tiles
(LJPEG-compressed) still have padding,
yet the DNG image sizes specify that it has to be discarded.

What is even worse, the image width is not multiple of two,
and the LJPEG's components-per-pixel is 2, so we have to
very-special-handle this case, to not completely discard
that last required block (then we'd be producing
nondeterministic garbage in those last few columns),
but also not fully decode it, because we don't have
anywhere to write it,

We could, of course, introduce something like
"internal padding columnts", in fact we already
pad the rows to be 16-byte aligned, but that padding
is used for ASAN overflow detection.
So right now i'm not seeing any more reasonable fix.

:/

Fixes #12239

History

#1 Updated by Roman Lebedev about 1 year ago

  • System changed from Windows to all
  • Affected Version changed from 2.4.4 to git master branch
  • Assignee set to Roman Lebedev

(as disscussed in https://discuss.pixls.us/t/darktable-unable-to-process-dng-from-panasonic-lx1/8025/15) Please contribute a CC0-licensed raw sample (straight from camera) to the https://raw.pixls.us/

#2 Updated by Roman Lebedev about 1 year ago

  • Subject changed from Darktable unable to process DNG from Panasonic LX1 to Darktable unable to process DNG converted from Panasonic LX1 raw

#4 Updated by Roman Lebedev about 1 year ago

  • % Done changed from 0 to 10
  • Status changed from New to Confirmed

#5 Updated by Roman Lebedev about 1 year ago

Damn, i'm looking into this, and it's super ugly.
Not sure what they are thinking producing such DNG's.

#6 Updated by Roman Lebedev about 1 year ago

  • % Done changed from 10 to 100
  • Status changed from Confirmed to Fixed

#7 Updated by Roman Lebedev about 1 year ago

  • Target version set to 2.6.0

Also available in: Atom PDF

Go to top