Project

General

Profile

Bug #12208

Bug #11581: Huffmantable is broken.

[2/3] Regression: huffmantable is bad for last decode

Added by Roman Lebedev about 1 year ago. Updated 5 months ago.

Status:
Fixed
Priority:
High
Assignee:
Category:
-
Target version:
-
Start date:
05/19/2018
Due date:
% Done:

100%

Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Copied from https://github.com/darktable-org/rawspeed/issues/128

Some raws appear not to have padding at the end, so when we do `bs.fill(32);`, we fail.
Changing https://github.com/darktable-org/rawspeed/blob/d41fd6dadc161d1c0bb56463dc35263779fa02f1/src/librawspeed/decompressors/HuffmanTable.h#L309
```diff
-bs.fill(32);
+bs.fill(maxCodePlusDiffLength());
```
seems to help somewhat, but i don't know the full solution yet.


Related issues

Duplicated by darktable - Bug #12494: Buffer overflow read in BitStream | [temperature] failed to read camera while balance information Closed: invalid 12/25/2018
Duplicated by darktable - Bug #12528: Cannot read camera white balance Duplicate 01/06/2019
Duplicated by darktable - Camera Support #12554: Failed to read white balance information: "DSC_XXX.NEF" Duplicate 01/16/2019

Associated revisions

Revision 79dc3028
Added by Roman Lebedev 5 months ago

RawSpeed submodule update: nikon 'last pixel' fix, perf tuning, camera support.

  • Preliminary Phase One P30 camera support ('bad column' handling missing)
  • Sony RX100M6 support

Refs. #12509
Fixes #12208.
Refs. #12207

History

#1 Updated by Roman Lebedev 5 months ago

  • Duplicated by Bug #12494: Buffer overflow read in BitStream | [temperature] failed to read camera while balance information added

#2 Updated by Roman Lebedev 5 months ago

  • % Done changed from 0 to 50
  • Status changed from New to In Progress

#3 Updated by Roman Lebedev 5 months ago

  • % Done changed from 50 to 70
  • Status changed from In Progress to Patch attached

#4 Updated by Roman Lebedev 5 months ago

  • Status changed from Patch attached to Fixed
  • % Done changed from 70 to 100

#5 Updated by Roman Lebedev 5 months ago

  • Duplicated by Bug #12528: Cannot read camera white balance added

#6 Updated by Roman Lebedev 4 months ago

Also available in: Atom PDF