Project

General

Profile

Camera Support #12026

Panasonic Lumix G9 - SH2 burst mode darkroom cannot read camera white balance info

Added by paul sorenson 10 months ago. Updated 8 months ago.

Status:
Fixed
Priority:
Low
Assignee:
Roman Lebedev
Category:
Darkroom
Target version:
2.6.0
Start date:
02/22/2018
Due date:
% Done:

100%

Affected Version:
git master branch

Description

Darkoom "failed to read camera white balance information from `P1000951.RW2'!"

I uploaded the image but don't see it in the repo and therefore have no link.

This does not occur with:
  1. single shot mode
  2. "H" burst mode

The example I uploaded is SH2 mode ("Burst shot 2 - using electronic shutter"). Lighttable displays the thumbnails but darkroom will not load the image.

Although I have tagged this as "camera support" I wonder if it makes sense for darkroom to load the image in spite of not being able to read the camera white balance info.

Actual darktable version showing: 2.4.1-1.fc27 which I built from source.

Associated revisions

Revision fd724e55
Added by Roman Lebedev 10 months ago

RawSpeed submodule update: TIFF/CIFF rewrite/hardening, RW2 sanity check loosening.

Fixes #12026.

History

#1 Updated by Roman Lebedev 10 months ago

  • Status changed from New to Triaged
  • Assignee set to Roman Lebedev
  • % Done changed from 0 to 20

The actual error is displayed in console:

$ /opt/darktable/bin/darktable /tmp/P1000951.RW2 
[rawspeed] (P1000951.RW2) rawspeed::PanasonicDecompressor::PanasonicDecompressor(const rawspeed::RawImage &, const rawspeed::ByteStream &, bool, rawspeed::uint32), line 48: Unexpected image dimensions found: (5264; 3912)

So this fails https://github.com/darktable-org/rawspeed/blob/70b99ab97a6c4375da677318d1d9f05b4eee7857/src/librawspeed/decompressors/PanasonicDecompressor.cpp#L46-L48
So it's not he wb reading problem, it really can't read the image.

The image you got is (5264; 3912), and it expects (5488; 3904) max.
That check was introduced as quick band-aid for fuzzing to somehow limit the maximal image size
(because otherwise it would be able to come up with something like (10000; 10000), which would be considered an overflow.)

But now that the actual math (to compute the expected input data size for a given image dimensions) was added,
i think i can relax/remove that check.

#2 Updated by Roman Lebedev 10 months ago

That being said, paul, could you please contribute the full sample set for that camera (to RPU), namely:
  • normal shutter: all 4 aspect ratios (yes, i know it produces the same raw)
  • every other shutter speed, 4:3 aspect ratio.
    (yes, i know there are already a samples for that camera, please do upload all the samples i asked regardless)

As usual, the camera needs to be stable and the content of all the samples needs to be as static as possible.

#3 Updated by paul sorenson 10 months ago

Uploaded P1000989 - P1001011 RW2.
There may be a couple of duplicate aspect ratio shots.

#4 Updated by Roman Lebedev 10 months ago

paul sorenson wrote:

Uploaded P1000989 - P1001011 RW2.
There may be a couple of duplicate aspect ratio shots.

Uhm, that is quite the opposite from what i have asked:

normal shutter: all 4 aspect ratios (yes, i know it produces the same raw)
every other shutter speed (edit: [SH2]/[SH1]/[SH2 PRE]/[SH1 PRE]), 4:3 aspect ratio.
(yes, i know there are already a samples for that camera, please do upload all the samples i asked regardless)

So that should have been 8 samples, at most.

Anyway...

#5 Updated by Roman Lebedev 10 months ago

  • Status changed from Triaged to Fixed
  • % Done changed from 20 to 100

#6 Updated by paul sorenson 10 months ago

Well it may not be what you wanted but you did ask for all "shutter speeds". If you wanted samples from all "burst modes" then I would have obliged ;)

I will upload some when I get a chance.

#7 Updated by Roman Lebedev 10 months ago

paul sorenson wrote:

Well it may not be what you wanted but you did ask for all "shutter speeds". If you wanted samples from all "burst modes" then I would have obliged ;)

I will upload some when I get a chance.

Duh, lol, sorry :)
Indeed, i confused "shutter speeds" and "burst modes" there :)
(Still, take all the "burst modes" samples with just 4:3 aspect ratio)

#8 Updated by paul sorenson 10 months ago

9 images uploaded (bonus M burst mode).
I annotated the mode in the comment but with some many images in my directory its possible I got it wrong.

#9 Updated by Roman Lebedev 8 months ago

  • Target version set to 2.6.0

Also available in: Atom PDF