Project

General

Profile

Bug #11977

Generated Noise Profiles for Panasonic TZ70 Not Found

Added by Chris Elston about 1 year ago. Updated about 1 year ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
01/29/2018
Due date:
% Done:

100%

Affected Version:
2.4.1
System:
other GNU/Linux
bitness:
64-bit
hardware architecture:
amd64/x86

Description

I've attempted to generate noise profiles for the Panasonic TZ70 using the gen-profile script (after hacking it slightly to deal with the issue referenced in Bug #11963).

When running those profiles against some sample images (by running darktable --noiseprofiles presets.json), none of my test images are being matched by the Denoise (Profiled) module. Normally I'd expect to see 'found match for ISOxxx' in the module but with these, I'm not getting that, even with raw files that appear to match (using the exif data) on model, manufacturer and ISO.

I've also tried incorporating my generated presets.json into /usr/share/darktable/noiseprofiles.json, with the same result.

On a related note, when I set ISO to auto, I get a lot of ISO values that don't match those available for selection within the camera. Should I expect the denoise module to interpolate between the ISO values that I have taken images for?

I've attached my generated profiles for info along with one of the raw files I've been testing with

dt-noiseprofile-20180128.tar.gz - noise profile presets (8.96 MB) Chris Elston, 01/29/2018 03:36 PM

P1010028.RW2 - test raw file (12.7 MB) Chris Elston, 01/29/2018 03:38 PM

dt-noiseprofile-20180129.tar.gz (8.41 MB) Chris Elston, 01/29/2018 11:53 PM

Associated revisions

Revision 3736d068
Added by Stefan Schöfegger about 1 year ago

noise profile: Add Panasonic DMC-TZ70 / TZ71 / ZS50, fixes #11977

Revision a143f227
Added by Stefan Schöfegger about 1 year ago

noise profile: Add Panasonic DMC-TZ70 / TZ71 / ZS50, fixes #11977

(cherry picked from commit 3736d06869a1b75b6f8eed495eee6857ec712bff)

History

#1 Updated by Chris Elston about 1 year ago

Some slightly better (I think) noise profile presets, without the camera movement that was in the previous set, but still the same issue that they aren't being picked up by the module.

#2 Updated by Stefan Schöfegger about 1 year ago

darktable -d control gives

[noiseprofile] looking for maker `Panasonic', model `DMC-TZ71'
[noiseprofile] found 13 makers
[noiseprofile] found `Panasonic' as `Panasonic'
[noiseprofile] found 31 models

This is because TZ70 is defined as alias of TZ71 in https://github.com/darktable-org/rawspeed/blob/develop/data/cameras.xml (line 7020) but profile.json is written with the exiv data of the images. This is, of course, no good solution.

#3 Updated by Chris Elston about 1 year ago

Thanks. I've renamed TZ70 to TZ71 in presets.json (the second set attached) and retested - seems to have good results on my test images, though whether that's a long-term solution I don't know.

Now I just need to work out how to handle the intermediate ISOs (e.g. ISO 160) - I can't figure out how to set them manually to take images for profiling. Could the module be amended to interpolate between the recorded ISO settings?

#4 Updated by Stefan Schöfegger about 1 year ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

#5 Updated by Stefan Schöfegger about 1 year ago

The module can interpolate between recorded iso levels.

#6 Updated by Chris Elston about 1 year ago

So it can. I think the image I tested it on was holding onto a setting from one of my previous (failed) tests - I deleted my history stack and now it works fine.

Thanks very much for your help.

#7 Updated by Roman Lebedev about 1 year ago

  • Target version set to 2.6.0

Also available in: Atom PDF