Project

General

Profile

Bug #11931

Web Gallery - files with quote(s) in their name are not opened

Added by manu pintor 3 months ago. Updated 3 months ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
Lighttable
Target version:
Start date:
01/13/2018
Due date:
% Done:

100%

Affected Version:
2.4.0
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

After exporting to a web gallery and viewing the resulting page in the browser, thumbnails of files with quote(s) in their name are not opened when clicked on.

Example: "Tom's face.jpg" won't open and be seen in normal size when you click on its thumbnail.

This appears to be related to the following sequence in index.html as generated:

var items = [ {
src: 'Tom's face_1600.jpg',
w: 640,
h: 427,
msrc: 'Tom's face_1600-thumb.jpg',
},
];

Replacing quotes by double-quotes in the src and msrc lines is the workaround I found so far.

Associated revisions

Revision 4cef1a21
Added by Pascal Obry 3 months ago

galery: properly escape filename & thumbname.

Fixes #11931.

Revision 800483bb
Added by Pascal Obry 3 months ago

galery: properly escape filename & thumbname.

Fixes #11931.

(cherry picked from commit 4cef1a2112973299b367360f31226ef5d1e26889)

History

#1 Updated by Pascal Obry 3 months ago

  • % Done changed from 0 to 100
  • Assignee set to Pascal Obry
  • Status changed from New to Fixed

Fixed.

#2 Updated by Roman Lebedev 3 months ago

  • Target version set to 2.6.0

Also available in: Atom PDF