Project

General

Profile

Bug #11930

Move hardcoded color values to the CSS

Added by Jan Mussche 6 months ago. Updated 5 months ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
General
Target version:
Start date:
01/13/2018
Due date:
% Done:

100%

Affected Version:
2.4.0
System:
other GNU/Linux
bitness:
64-bit
hardware architecture:
amd64/x86

Description

I've been busy changing the theme Darktable uses and I changed the css file for that. Most parts of the screen are looking good, except in Darkroom the windows used by the modules. Here white text is used (hardcoded) and when I change the background to a lighter version, the text is invisible.
Same happens in the History field in Darkroom where at the bottom it says: compress history stack

Screenshot_20180113_165453.png - Example of light text on light background (27.4 KB) Jan Mussche, 01/13/2018 05:58 PM

Associated revisions

Revision 27e7a0da
Added by Peter Budai 5 months ago

Fix #11930: CSS themes: remove hard-coded font colors from bauhaus widgets (#1648)

  • Fix #11930: Remove hard-coded font colors from bauhaus
  • Remove default color values from bauhaus
    Use theme foreground color for darktable title and "compress history stack" button

History

#1 Updated by Jan Mussche 6 months ago

Also the on/off buttons in the modules windows are not controlled by the css file. They are also white and become invisible in the off position. When the module is switched on the button receives the color from the fg_color parameter, something which can be chosen in the css file.

Name darktable (top left in logo) plus version number is hardcoded.

base_color, darkroom_bg_color, darkroom_preview_bg_color, lighttable_bg_color, lighttable_preview_bg_color, brush_color, brush_trace, dark_bg_color all get a color value defined but are not used in the css file.

Used colors for tooltips are not the defined tooltip_bg_color and tooltip_fg_color.
text_color is used 3 times as background color which is not wrong but a bit strange.

#2 Updated by Tobias Ellinghaus 6 months ago

  • Status changed from New to Triaged
  • % Done changed from 0 to 20

#3 Updated by Tobias Ellinghaus 6 months ago

  • Subject changed from Change theme to a light theme which resembles KDE's Breeze light to Move hardcoded color values to the CSS

#4 Updated by Aurélien PIERRE 6 months ago

mmoy already did a neutral grey theme. The result is quite good, here is the CSS :

@import '/usr/share/darktable/darktable.css';

@define-color bg_color #7F7F7F;
@define-color plugin_bg_color #333;
@define-color fg_color #eee;
@define-color base_color #444;
@define-color text_color #eee;
@define-color selected_bg_color #666;
@define-color selected_fg_color #eee;
@define-color tooltip_bg_color #BEBEBE;
@define-color tooltip_fg_color #111;
@define-color really_dark_bg_color #595959;

@define-color darkroom_bg_color #777777;
@define-color darkroom_preview_bg_color shade(@darkroom_bg_color, .8);
@define-color lighttable_bg_color @darkroom_bg_color;
@define-color lighttable_preview_bg_color shade(@lighttable_bg_color, .8);

#6 Updated by Peter Budai 5 months ago

  • Status changed from Triaged to Fixed
  • % Done changed from 20 to 100

#7 Updated by Roman Lebedev 5 months ago

  • Target version changed from Candidate for next major release to 2.6.0

Also available in: Atom PDF