Project

General

Profile

Feature #11924

Allow hot pixel module fusion like other modules

Added by St├ęphane Gourichon 6 months ago. Updated 6 months ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
01/12/2018
Due date:
% Done:

100%

Affected Version:
2.4.0
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Context

  • Editing a photo in darktable.
  • Sometimes image has a few actual hot pixels to fix, but also some areas where there aren't actually hot pixels, yet "hot pixels" modules muddles them.
  • Area wrongly picked by "hot pixels" module are mostly sun or flash reflections in tiny elements (jewelry, gemstones, sometimes zippers).

Problem

  • The problem is when hot pixels module does not catch all actual hot pixels, but damages pixels that should be left as is.
  • Other situations I could fix by tuning "hot pixels" parameters, but in this case no tuning worked.
  • Indeed, tiny reflections are bright near-isolated pixels, but they make sense in the photograph. Jewelry makes a number of tiny reflections. Some pixels are suppressed by "hot pixels" module, which looks unnatural.

Solution

"Hot pixels" module uses a simple local algorithm and it's good this way. IMHO there's no point in aiming to make it perfect.

A more flexible solution: let "hot pixels" modules to allow blend modes, just like other modules. Then the user can easily use "drawn mask" to include or exclude areas.

This lets "hot pixels" module do a nice job where it belongs and not damage other areas, keeping the user in control.

Workaround

Currently, the only choice I see is to disable hot pixels module and manually fix the actual hot pixels with spot removal or low pass.

History

#1 Updated by Tobias Ellinghaus 6 months ago

I wouldn't be opposed to allow blending/masking in that module.

#3 Updated by Tobias Ellinghaus 6 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

#4 Updated by Roman Lebedev 6 months ago

  • Target version set to 2.6.0

Also available in: Atom PDF