Project

General

Profile

Camera Support #11842

Nikon D4 noise profile

Added by Jean-Luc Fornac 11 months ago. Updated 9 months ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
-
Target version:
Start date:
12/01/2017
Due date:
% Done:

100%

Affected Version:
git master branch

Description

hi

I have done a noise profile for Nikon D4. tell me if it's OK !

Some litle mofications are needed for me to be generate and work.

using gen-profile to capture images give a preset.json witch this kind of line

{"name": "D4 iso 50 Lo 1.0 50 Lo 1.0", "iso": 50 Lo 1.0 50 Lo 1.0, "a": [1.60730738710687e-06, 8.54191921029561e-07, 1.43365859065854e-06], "b": [5.37826561573961e-09, 1.64209734945457e-09, 3.77104251805431e-09]},

because exiv2 -P E 51200-1.nef | grep ISO give

Exif.Nikon3.ISOSpeed Undefined 4 0
Exif.Nikon3.ISOSettings Undefined 4 0
Exif.NikonIi.ISO Byte 1 51200
Exif.NikonIi.ISOExpansion Short 1 Hi 2.0
Exif.NikonIi.ISO2 Byte 1 51200
Exif.NikonIi.ISOExpansion2 Short 1 Hi 2.0
Exif.NikonSi02xx.ISO Byte 1 31
Exif.Nikon3.HighISONoiseReduction Short 1 Normal

and darktable detect an error in the file and give

./darktable --noiseprofiles ~/dnef_3/presets.json
[noiseprofile] error: parsing json from `/home/devjlf/dnef_3/presets.json' failed
/home/devjlf/dnef_3/presets.json:11:60: Erreur d'analyse : unexpected number `50', expected string constant

using gen-profile with exiting directory image give
===> Check profiling directory

===> List profiling input RAW images
--> Found ISO 100 image: /home/devjlf/dnef_3/100-1.nef
--> Found ISO 1000 image: /home/devjlf/dnef_3/1000-1.nef
--> Found ISO 10000 image: /home/devjlf/dnef_3/10000-1.nef
--> Found ISO 125 image: /home/devjlf/dnef_3/125-1.nef
--> Found ISO 1250 image: /home/devjlf/dnef_3/1250-1.nef
--> Found ISO 12800 image: /home/devjlf/dnef_3/12800-1.nef
--> Found ISO 16127 Hi 0.3 16127 Hi 0.3 image: /home/devjlf/dnef_3/14400-1.nef
./gen-profile: 1: eval: Bad substitution

So i have added 4 lines in subr.fr in get_image_iso() to work

if [ -z "$iso" -o "$iso" = "0" ]; then
iso=$(get_exif_key "$file" Exif.NikonIi.ISO)

ciso=$(echo $iso | cut -d' ' -f2)                               
if [ "$ciso" = "Hi" -o "$ciso" = "Lo" ]; then
iso=$(echo $iso | cut -d' ' -f1 )
fi
fi

hope that helps
bye

PS : attached presets.json with problems

dt-noiseprofile-20171201.tar.gz (7.68 MB) Jean-Luc Fornac, 12/01/2017 01:56 PM

presets.json_nogood (6 KB) Jean-Luc Fornac, 12/01/2017 01:58 PM

Associated revisions

Revision 1cbe3faa
Added by Stefan Schöfegger 10 months ago

noise profile: Add Nikon D4, refs #11842

Revision 1776e9f0
Added by Stefan Schöfegger 9 months ago

noise profile: read Hi/Lo iso values, refs #11580, fixes #11842

This fixes "./gen-profile: 1: eval: Bad substitution" error
during noise profile calculation with same nikon images.
Tested with images from #11580, fix is copied from #11842.

exiv2 reports {{{
$ exiv2 -g "Exif.NikonIi.ISO" -Pt DSC_1083.NEF
79
Lo 0.3
79
Lo 0.3
}}}
which can not be parsed correct with current script.

79 seems to be the correct iso value as it is reported from exiv2
without key argument. {{{
$ exiv2 DSC_1083.NEF | grep ISO
ISO speed : 79
}}}

Revision afa6441b
Added by Roman Lebedev 9 months ago

Merge pull request #1612 from schenlap/noise_nikon_iso

noise profile: read Hi/Lo iso values, refs #11580, fixes #11842

Revision 788127db
Added by Stefan Schöfegger 9 months ago

noise profile: read Hi/Lo iso values, refs #11580, fixes #11842

This fixes "./gen-profile: 1: eval: Bad substitution" error
during noise profile calculation with same nikon images.
Tested with images from #11580, fix is copied from #11842.

exiv2 reports {{{
$ exiv2 -g "Exif.NikonIi.ISO" -Pt DSC_1083.NEF
79
Lo 0.3
79
Lo 0.3
}}}
which can not be parsed correct with current script.

79 seems to be the correct iso value as it is reported from exiv2
without key argument. {{{
$ exiv2 DSC_1083.NEF | grep ISO
ISO speed : 79
}}}

(cherry picked from commit 1776e9f0c85b41cdb3871316f06032af18371930)

History

#1 Updated by Stefan Schöfegger 10 months ago

  • % Done changed from 0 to 50
  • Status changed from New to In Progress

noise profile added, i keep ticket open to fix ./gen-profile: 1: eval: Bad substitution

#2 Updated by Roman Lebedev 10 months ago

  • Target version changed from 2.4.0 to 2.6.0

#3 Updated by Stefan Schöfegger 9 months ago

  • % Done changed from 50 to 100
  • Status changed from In Progress to Fixed

Also available in: Atom PDF