Project

General

Profile

Bug #11815

keyboard arrow keys not working for sliders

Added by Heiko Bauke 9 days ago. Updated 6 days ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
11/11/2017
Due date:
% Done:

100%

Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

A few days I observed that it is no longer possible to change slider values via keyboard arrow keys. Currently I am running 2.3.0+1054~g91cb489b9-dirty under Gnome/Ubuntu 17.10 64 bit. I am not 100% sure, but I think this bug did not appear immediately after my upgrade to Ubuntu 17.10.

Associated revisions

Revision 618f39d5
Added by Tobias Ellinghaus 6 days ago

Fix arrow keys in bauhaus widgets in iops

Fixes #11815

History

#1 Updated by Roman Lebedev 9 days ago

  • % Done changed from 0 to 10
  • Status changed from New to Confirmed
commit c3679d3be6103ab2b3dff8f85ebe6c44e423833e
Author: Tobias Ellinghaus <me@houz.org>
Date:   Thu Oct 26 19:54:19 2017 +0200

    bauhaus: Don't grab focus when hovering with mouse

    This cause much grieve in the past. Please test thoroughly and report
    any problems!

It's kinda intentional.
U don't like it, i feel like it does not fix the actual bug, but it's symptoms.
But at the same time, i progressively feel like not touching any more code.

#2 Updated by Heiko Bauke 8 days ago

Hi,

Roman Lebedev wrote:

[...]
It's kinda intentional.
U don't like it, i feel like it does not fix the actual bug, but it's symptoms.
But at the same time, i progressively feel like not touching any more code.

when it is intended that hovering with mouse does not grab keyboard focus, focus should be grabbed after mouse click (left and right or right only). Otherwise the slider never gets keyboard focus. Focus should be transfered via right click (possibly in addition to a possible focus transfer via left click), because a left click almost always also changes the slider's value, which is not desirable.

#3 Updated by Roman Lebedev 8 days ago

Heiko Bauke wrote:

Hi,

Roman Lebedev wrote:

[...]
It's kinda intentional.
U don't like it, i feel like it does not fix the actual bug, but it's symptoms.
But at the same time, i progressively feel like not touching any more code.

when it is intended that hovering with mouse does not grab keyboard focus, focus should be grabbed after mouse click (left and right or right only).

Otherwise the slider never gets keyboard focus.

Wait, really? Oh well...

Focus should be transfered via right click (possibly in addition to a possible focus transfer via left click), because a left click almost always also changes the slider's value, which is not desirable.

#4 Updated by Heiko Bauke 8 days ago

Hi,

Roman Lebedev wrote:

Heiko Bauke wrote:

Otherwise the slider never gets keyboard focus.

Wait, really? Oh well...

it does not get keyboard focus in the sense that the arrow keys remain inactive what ever I do. Right clicking on the sider and entering a numerical value still works as expected. I think it is very useful to be able to change slider values via arrow/cursor keys, especially if one works with a touchpad only, rather than with a mouse. It is rather inconvenient to move the bent line extending from the triangular marker via a touchpad.

#5 Updated by Tobias Ellinghaus 7 days ago

  • Category changed from General to Darkroom
  • System changed from Ubuntu to all
  • % Done changed from 10 to 20
  • Status changed from Confirmed to Triaged

This just affect darkroom mode, in other views the focus works as intended (try export for example). The reason being that bauhaus widgets work a little different in image ops.

#6 Updated by Tobias Ellinghaus 6 days ago

  • % Done changed from 20 to 100
  • Status changed from Triaged to Fixed

Also available in: Atom PDF