Project

General

Profile

Bug #11758

undo crashes in spot removal

Added by Dan Torop 3 months ago. Updated about 2 months ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
Darkroom
Target version:
Start date:
10/04/2017
Due date:
% Done:

100%

Affected Version:
git master branch
System:
Debian
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Description

Using undo causes spot removal iop to crash.

Steps to reproduce

  • Open the "spot removal" module
  • Add a circle
  • Press control-z

Expected result

The circle is removed.

Actual result

Crash! A sample backtrace is attached.

darktable_bt_3VIN7Y.txt Magnifier - backtrace (54.6 KB) Dan Torop, 10/04/2017 06:27 PM

Associated revisions

Revision 7e5993ee
Added by Peter Budai 2 months ago

Checking for empty mask list before trying to write out to db. Fixes #11758

Revision 30673b69
Added by Pascal Obry 2 months ago

Merge pull request #1544 from peterbud/bugfix-11758

Checking for empty mask list. Fixes #11758

History

#1 Updated by Peter Budai 2 months ago

Confirmed. The same happens on Windows version as well.

#2 Updated by Tobias Ellinghaus 2 months ago

  • % Done changed from 0 to 20
  • Status changed from New to Triaged

ctrl-z doesn't crash for me, but subsequent tries to move the circles crashes in other parts of the mask code. So something is definitely broken.

#3 Updated by Pascal Obry 2 months ago

  • Assignee set to Pascal Obry

Same for me, it crashes as soon as I ctrl-z on this module. I'll have a look ASAP.

#4 Updated by Peter Budai 2 months ago

I had a PR for it but most likely not solving all the problems:
https://github.com/darktable-org/darktable/pull/1544

#5 Updated by Pascal Obry 2 months ago

  • Status changed from Triaged to Fixed
  • % Done changed from 20 to 100

Should be fixed now. Thanks.

#6 Updated by Roman Lebedev about 2 months ago

  • Target version set to 2.4.0

Also available in: Atom PDF