Project

General

Profile

Feature #11726

How to update lensfun db on Windows?

Added by Martin Pecka over 1 year ago. Updated over 1 year ago.

Status:
Closed: invalid
Priority:
Low
Assignee:
-
Category:
General
Target version:
Start date:
09/03/2017
Due date:
% Done:

0%

Affected Version:
git master branch
System:
Windows
bitness:
64-bit
hardware architecture:
amd64/x86

Description

I've just installed the 64bit Windows build, and it works great!

I just wanted to have my camera's calibration data in there, so I tried updating lensun db, but haven't found a nice way to do it.

First I tried to just download the data/db directory from lensfun master and copy it into C:\Program Files\darktable\share\lensfun\version_1 overwriting all files there. This did not work - darktable completely stopped to offer any cameras/lenses in the lens correction module.

Then I tried changing just the single file I need (mil-panasonic.xml) for its master version, also no success. I also tried removing the first line (doctype declaration), again with no success.

Then I resorted to just editing the original xml distributed with DT and added my records manually, and that worked.

So what's the suggested official procedure?

Lens Correction_Ubuntu.jpg (368 KB) Michel PETTE, 09/05/2017 10:14 PM

Path DT.jpg (117 KB) Michel PETTE, 09/05/2017 10:14 PM

Lens Correction_Windows.jpg (410 KB) Michel PETTE, 09/05/2017 10:14 PM

Lens list_Ubuntu.jpg (490 KB) Michel PETTE, 09/05/2017 11:31 PM

Lens list_Windows.jpg (461 KB) Michel PETTE, 09/05/2017 11:31 PM

Clipboard01.jpg (190 KB) Martin Pecka, 09/06/2017 12:58 AM

NK_39545.NEF (32.5 MB) Michel PETTE, 09/07/2017 11:52 PM

History

#1 Updated by Tobias Ellinghaus over 1 year ago

First, I update my local lensfun database before creating Windows packages, so the calibration data shipped should be up-to-date relative to that point in time. Of course, that is not a stable state as the lensfun database gets new entries all the time. So I understand the wish to update it manually. I would have expected that just replacing the files shipped by darktable would be enough. Maybe something corrupted the files when you downloaded them or something like that? Hard to tell.

#2 Updated by Peter Budai over 1 year ago

Martin what is the version number of your dt (top left corner)?

#3 Updated by Martin Pecka over 1 year ago

Peter Budai wrote:

Martin what is the version number of your dt (top left corner)?

2.3.0+866~gc23bd4a5a

Tomorrow, I'll package the db files I'm putting in the lensfun directory so that you can also try it yourself.

#4 Updated by Peter Budai over 1 year ago

Martin thats an old build with outdated lensfun db.
Please check the latest build here:
https://discuss.pixls.us/t/darktable-for-windows/4966

As of this writing this is the latest:
darktable-2.3.0+882~gd1e1e8d17-win64.exe

That contains an up-to-date lensfun db, please download and install it.

#5 Updated by Tobias Ellinghaus over 1 year ago

  • % Done changed from 0 to 20
  • Status changed from New to Incomplete

It would still be interesting to find out why updating the db didn't work for you. So please proceed with packing and uploading it. :-)

#6 Updated by Michel PETTE over 1 year ago

So i try to explain my similar problem... (sorry i'm not fluent)
I have a D750 with a 35 mm Nikkor lens f1.8.
On Ubuntu Darktable 2.2.5 the association slr + lens is recognized
The same image on Windows 10 Darktable 2.3.0 + 882 the association is not recognized
What happened between DT and Lenfun? a path not recognized?
Just verify, SLR and Lens are the both present in the two xml files (Ubuntu and Windows)

#7 Updated by Tobias Ellinghaus over 1 year ago

  1. What is you Windows system language?
  2. In what path did you install darktable?
  3. Do you see any camera or lens models in the lenscorrection module at all?
  4. Can you take a screenshot of the module please?

Tobias

#8 Updated by Michel PETTE over 1 year ago

What is you Windows system language?_====> French
_In what path did you install darktable?
C:\Programmes\Darktable\bin\darktable.exe
Do you see any camera or lens models in the lenscorrection module at all? ==> I see several lens, but not my Nikkor AF-S 35mm f 1.8G ED; in the list there are two 35 mm one is is the AI-S 35 mm f2.0 et the other AF 35 mm f2.0D
Can you take a screenshot of the module please? Yes see attach

#9 Updated by Michel PETTE over 1 year ago

To complete the subject, I took two new screenshot, list of lens on Windows and Ubuntu.

#10 Updated by Martin Pecka over 1 year ago

Tobias Ellinghaus wrote:

It would still be interesting to find out why updating the db didn't work for you. So please proceed with packing and uploading it. :-)

I traced the problem the the very first tag in the new file.

The original file from installer starts with

<lensdatabase version="1">

But the file downloaded from lensfun master starts with

<lensdatabase version="2">

I've verified that copying the file from master and changing the version to 1 solves the issue for me.

I attach a screenshot of the list of cameras when I load DT with the "version 2" file. There are no lenses (at all!), and the list of cameras is shorter than usual.

#11 Updated by Tobias Ellinghaus over 1 year ago

Ok, so we seem to have two different issues here.

Martin: As you found out yourself, the version 2 databases are not compatible with the version of lensfun (0.3.2) we ship. http://wilson.bronger.org/lensfun-db/version_1.tar.bz2 should work.

Michel: The database we have in darktable 2.3.0+882 should support that lens. Could you please upload a file from your camera that doesn't get properly recognized?

#12 Updated by Martin Pecka over 1 year ago

Tobias Ellinghaus wrote:

Martin: As you found out yourself, the version 2 databases are not compatible with the version of lensfun (0.3.2) we ship. http://wilson.bronger.org/lensfun-db/version_1.tar.bz2 should work.

Thanks Tobias, this seems to be the official solution for lensfun updates on Windows. Is there a place (other than this bugreport) to mention this information?

#13 Updated by Michel PETTE over 1 year ago

@Tobias,
See attach, a raw file D750 and lens Nikkor AF-S 35mm f1.8G; Slr et lens are recognized with the DT 2.2.5 on Ubuntu but not with DT 2.3 on Windows

#14 Updated by Tobias Ellinghaus over 1 year ago

For me that image works just fine under Windows. Could you please verify that you have the latest build of darktable installed (2.3.0+898), available from https://discuss.pixls.us/t/darktable-for-windows/4966/83 and try again? Maybe remove the image from darktable and import it again, or try resetting the lens correction module (the small power icon in its header).

#15 Updated by Michel PETTE over 1 year ago

@Tobias,
Could you please verify that you have the latest build of darktable installed (2.3.0+898)===> Yes I have
try again ====> Same Problem
Maybe remove the image from darktable and import it again > Same Problem
try resetting the lens correction module > Same Prblem ...... BUT i have an Idea!!!
I have a look in the directory C:/Users/Michel/AppData/local/lensfun, I notice a difference between the content (nb of Ko) of this directory and the directory in C:/Programmes/darktable/share/lenfun.
I replace the first directory by the second ....and YOUPI!!!
I think that "uninstall" don't work completely when we change the version. "I remove the old version before install the new"
I hope my english comprehensive and my notice wil be use to the other.

#16 Updated by Peter Budai over 1 year ago

the darktable installer is installing lensfun to:

[dt install directory]\share\lensfun

Your local lensfun (C:\Users\[username]\Appdata\local\lensfun) should come somewhere else. Do you have any other app installed which might using lensfun?

#17 Updated by Tobias Ellinghaus over 1 year ago

  • % Done changed from 20 to 0
  • Status changed from Incomplete to Closed: invalid

Indeed, that local lensfun database wasn't installed by darktable.

#18 Updated by Michel PETTE over 1 year ago

Peter and Tobias: OK I note, and probably the lensfun directory in AppData/local come from the DT Partha version. I remove it.
But I don't understand why this new version was perturbated if the darktable installer don't install lensfun in AppData/local.
Thanks for your help.

#19 Updated by Tobias Ellinghaus over 1 year ago

Preferring a lensfun db in the user's home directory is what allows people to update their lensfun database without requiring a new release of the program.

#20 Updated by Roman Lebedev over 1 year ago

  • Target version set to 2.4.0

Also available in: Atom PDF