Project

General

Profile

Bug #11723

Watermarks module

Added by Michel PETTE over 1 year ago. Updated over 1 year ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
09/02/2017
Due date:
% Done:

100%

Affected Version:
git master branch
System:
Windows
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Watermarks module does not work correctly, when I write a simple-text Only rectangle appear on the view with the number of letters. On the vignette the text is correct.
The vignette in the lighttable is also correct.

WatermarksModule_01.JPG (129 KB) Michel PETTE, 09/02/2017 10:50 PM

Associated revisions

Revision 9f10c211
Added by Tobias Ellinghaus over 1 year ago

Fix #11723: Fix a threading issue in rsvg/cairo

This is mitigating the bug by running less of watermark's process() in
parallel and putting more into a mutex. Not ideal. Eventually we might
want to look at moving more of the setup code into commit_params().

History

#1 Updated by Roman Lebedev over 1 year ago

  • Status changed from New to Incomplete
  • % Done changed from 0 to 20

Does that happen with ASCII-only text?
Does that happen not happen with some different font?

#2 Updated by Peter Budai over 1 year ago

Confirmed. Only happens with certain fonts.
With some fonts what seems to work fine:
  • Arial
  • Arial Bold
  • Arial Bold Oblique
  • Agency FB Normal
  • Agency FB Bold
  • Agency FB Bold Oblique
What does not work:
  • Arial Bold Oblique
  • Agency FB Oblique
Interestingly:
  • when you zoom out (mouse wheel scroll + CTRL), then momentarily you can see the properly rendered text.
  • Why it shows as "Oblique" in the font name on an English system? Isn't it supposed to be "Italic"? At least on the fonts control panel app these shown up as "Arial Italic"

#3 Updated by Roman Lebedev over 1 year ago

Peter Budai wrote:

Confirmed. Only happens with certain fonts.

Sounds like user error, closed: invalid then.

With some fonts what seems to work fine:
  • Arial
  • Arial Bold
  • Arial Bold Oblique
  • Agency FB Normal
  • Agency FB Bold
  • Agency FB Bold Oblique
What does not work:
  • Arial Bold Oblique
  • Agency FB Oblique
Interestingly:
  • when you zoom out (mouse wheel scroll + CTRL), then momentarily you can see the properly rendered text.
  • Why it shows as "Oblique" in the font name on an English system? Isn't it supposed to be "Italic"? At least on the fonts control panel app these shown up as "Arial Italic"

#4 Updated by Tobias Ellinghaus over 1 year ago

Either that or an upstream rsvg bug.

#5 Updated by Richard Wonka over 1 year ago

Using a particular font (that recreates the bug) is a user error?

I don't understand.

#6 Updated by Peter Budai over 1 year ago

I'd not close it yet. It is apparent the only special font cases are impacted. I did some more research, and I have a feeling it has to do something with faux font faces:
http://tavmjong.free.fr/blog/?p=822

In Inkscape ultimately they have disabled those faux font faces:
https://gitlab.com/inkscape/inkscape/commit/4a5edfac0c0408d97c1ecd1b547cea87d06ab113

If the issue s related to that, maybe we should disable here also the faux font faces?

#7 Updated by Peter Budai over 1 year ago

Ok I have to row back. It has nothing to do with font faces.

Even with basic font you can reproduce the error.
1. Select any font
2. Switch to another font a few times, until you get these rectangles (I have managed to have them with simple Arial Normal)
3. Close darktable
4. Restart it, voila renders properly

#9 Updated by Tobias Ellinghaus over 1 year ago

  • Status changed from Incomplete to Fixed
  • % Done changed from 20 to 100

#10 Updated by Roman Lebedev over 1 year ago

  • Target version set to 2.4.0

Also available in: Atom PDF