Project

General

Profile

Bug #11624

Artifacts from global tonemap

Added by Stéphane JOLY almost 2 years ago. Updated almost 2 years ago.

Status:
Fixed
Priority:
Low
Category:
Darkroom
Target version:
Start date:
05/28/2017
Due date:
% Done:

100%

Affected Version:
2.2.4
System:
other GNU/Linux
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hello,

I do not know where to report a bug, so I do it here. I work under Manjaro Linux, my version of Darktable is 2.2.4. When I use the "Global Tones" function, I have funny things that happen. For that, I let you look at the picture without the preset and with the preset activated in the comment (there are like bands and squares that form on the export of the photo). Hoping that a solution could be found.

See : http://www.flickr.com/photos/tatananas/34927793395/in/dateposted...

Thanks,
Regards

DSC_9467.jpg (11.8 MB) Stéphane JOLY, 05/31/2017 09:56 PM

DSC_9467.NEF.xmp (5.51 KB) Stéphane JOLY, 05/31/2017 09:57 PM

Associated revisions

Revision 3a1d6399
Added by Ulrich Pegelow almost 2 years ago

tiling: add option to disable tiling from within commit_params(); fixes #11624

History

#1 Updated by Tobias Ellinghaus almost 2 years ago

  • Status changed from New to Incomplete
  • % Done changed from 0 to 20

I assume you mean "global tonemap"? And where are there blocky artifacts in the image? To me it looks fine.

Edit: I see, there was a link in the comments of the flickr post. Please upload the PNG, raw and XMP here.

#2 Updated by Hans Bull almost 2 years ago

I have the same problem, current git version (but alread existed in 2.2.2 if I remember correctly) on Ubuntu 16.04 x64, happens w/ or w/o OpenCL.
Here the files:
http://74.91.161.160/DSC_5408.jpg
http://74.91.161.160/DSC_5408.NEF
http://74.91.161.160/DSC_5408.NEF.xmp
Horizontal band in the water. Problem with tiling?
Thanks,
HB

#3 Updated by Tobias Ellinghaus almost 2 years ago

  • Subject changed from Darktable 2.2.4 Global Tones to Artefacts from global tonemap

#4 Updated by Tobias Ellinghaus almost 2 years ago

  • Subject changed from Artefacts from global tonemap to Artifacts from global tonemap

#5 Updated by Ulrich Pegelow almost 2 years ago

I don't see any blocky artifacts in the flickr images either.

Concerning the topic mentioned in post nb. 2: the drago operator in global tonemap requires to see the full image in order to get L_max. This excludes tiling. In the OpenCL path we take according action:

  // check if we are in a tiling context and want OPERATOR_DRAGO. This does not work as drago
  // needs the maximum L-value of the whole image. Let's return FALSE, which will then fall back
  // to cpu processing
  if(piece->pipe->tiling && d->operator== OPERATOR_DRAGO) return FALSE;

Tiling could only happen due to some unfortunate settings in the CPU path. Please run darktable with '-d dev' and post your output.

#6 Updated by Stéphane JOLY almost 2 years ago

Tobias Ellinghaus wrote:

I assume you mean "global tonemap"? And where are there blocky artifacts in the image? To me it looks fine.

Edit: I see, there was a link in the comments of the flickr post. Please upload the PNG, raw and XMP here.

I send the images as requested. I noticed something, if I reduce the size of the image from Dartable (1450x1450), the artifacts disappear :

http://tatananas54.free.fr/ReadmineDarktable/11624/DSC_9467.NEF
http://tatananas54.free.fr/ReadmineDarktable/11624/DSC_9467.NEF.xmp
http://tatananas54.free.fr/ReadmineDarktable/11624/DSC_9467.jpg
http://tatananas54.free.fr/ReadmineDarktable/11624/DSC_9467_01.jpg (no bug reduce the size of the image ?)

Vertical bands to the right of the image.
This is the first time I make a bug, I do as I can, I'm bad in English, yes is "global tonemap" just look xmp file.

#7 Updated by Tobias Ellinghaus almost 2 years ago

Please add those files here in the bug tracker. For some reason I can't connect to your website. It always times out.

#8 Updated by Ulrich Pegelow almost 2 years ago

Vertical bands to the right of the image.

Those are visible and indeed they indicate a tiling issue. Please start darktable with '-d dev' from a console and paste the output here.

#9 Updated by Stéphane JOLY almost 2 years ago

Tobias Ellinghaus wrote:

Please add those files here in the bug tracker. For some reason I can't connect to your website. It always times out.

Ok i try to send it on the bug tracker.
41Mo
My NEF file maybe is to big and "bug tracker" is not accept my NEF.7z file. Size : 41 Mo, he write : Error, why ?

#10 Updated by Stéphane JOLY almost 2 years ago

Ulrich Pegelow wrote:

Vertical bands to the right of the image.

Those are visible and indeed they indicate a tiling issue. Please start darktable with '-d dev' from a console and paste the output here.

[steph@Fixe ~]$ darktable -d dev
wait time 0,140660s
pixelpipe cacheline 0 used 0 by 18446744073709551615
pixelpipe cacheline 1 used 0 by 18446744073709551615
cache hit rate so far: -nan
wait time 0,101327s
wait time 0,110946s
wait time 0,120878s
wait time 0,130938s
pixelpipe cacheline 0 used 0 by 18446744073709551615
pixelpipe cacheline 1 used 0 by 18446744073709551615
pixelpipe cacheline 2 used 0 by 18446744073709551615
pixelpipe cacheline 3 used 0 by 18446744073709551615
pixelpipe cacheline 4 used 0 by 18446744073709551615
cache hit rate so far: -nan
pixelpipe cacheline 0 used 0 by 18446744073709551615
pixelpipe cacheline 1 used 0 by 18446744073709551615
pixelpipe cacheline 2 used 0 by 18446744073709551615
pixelpipe cacheline 3 used 0 by 18446744073709551615
pixelpipe cacheline 4 used 0 by 18446744073709551615
cache hit rate so far: -nan
pixelpipe cacheline 0 used 0 by 18446744073709551615
pixelpipe cacheline 1 used 0 by 18446744073709551615
cache hit rate so far: -nan
pixelpipe cacheline 0 used 0 by 18446744073709551615
pixelpipe cacheline 1 used 0 by 18446744073709551615
cache hit rate so far: -nan
pixelpipe cacheline 0 used 0 by 18446744073709551615
pixelpipe cacheline 1 used 0 by 18446744073709551615
cache hit rate so far: -nan
[default_process_tiling_roi] use tiling on module 'demosaic' for image with full input size 7380 x 4928
[default_process_tiling_roi] (2 x 1) tiles with max dimensions 5968 x 4928
[default_process_tiling_roi] tile (0, 0) with 3698 x 4928 at origin [0, 0]
[default_process_tiling_roi] tile (1, 0) with 3706 x 4928 at origin [3672, 0]
pixelpipe cacheline 0 used 0 by 18446744073709551615
pixelpipe cacheline 1 used 0 by 18446744073709551615
cache hit rate so far: -nan
[default_process_tiling_roi] use tiling on module 'demosaic' for image with full input size 7380 x 4928
[default_process_tiling_roi] (2 x 1) tiles with max dimensions 5968 x 4928
[default_process_tiling_roi] tile (0, 0) with 3698 x 4928 at origin [0, 0]
[default_process_tiling_roi] tile (1, 0) with 3706 x 4928 at origin [3672, 0]
[default_process_tiling_ptp] use tiling on module 'globaltonemap' for image with full size 4928 x 7380
[default_process_tiling_ptp] (5 x 4) tiles with max dimensions 2385 x 3572 and overlap 592
[default_process_tiling_ptp] tile (0, 0) with 2385 x 3572 at origin [0, 0]
[default_process_tiling_ptp] tile (0, 1) with 2385 x 3572 at origin [0, 2388]
[default_process_tiling_ptp] tile (0, 2) with 2385 x 2604 at origin [0, 4776]
[default_process_tiling_ptp] tile (1, 0) with 2385 x 3572 at origin [1201, 0]
[default_process_tiling_ptp] tile (1, 1) with 2385 x 3572 at origin [1201, 2388]
[default_process_tiling_ptp] tile (1, 2) with 2385 x 2604 at origin [1201, 4776]
[default_process_tiling_ptp] tile (2, 0) with 2385 x 3572 at origin [2402, 0]
[default_process_tiling_ptp] tile (2, 1) with 2385 x 3572 at origin [2402, 2388]
[default_process_tiling_ptp] tile (2, 2) with 2385 x 2604 at origin [2402, 4776]
[default_process_tiling_ptp] tile (3, 0) with 1325 x 3572 at origin [3603, 0]
[default_process_tiling_ptp] tile (3, 1) with 1325 x 3572 at origin [3603, 2388]
[default_process_tiling_ptp] tile (3, 2) with 1325 x 2604 at origin [3603, 4776]
[export_job] exported to `/tmp/DSC_9467_02.jpg'
[steph@Fixe ~]$

#11 Updated by Ulrich Pegelow almost 2 years ago

  • Status changed from Incomplete to In Progress
  • Assignee set to Ulrich Pegelow
  • % Done changed from 20 to 50
[default_process_tiling_ptp] use tiling on module 'globaltonemap' for image with full size 4928 x 7380
[default_process_tiling_ptp] (5 x 4) tiles with max dimensions 2385 x 3572 and overlap 592

Yepp, that's the problem. Global tonemap should not go tiling with the drago operator. I'll gonna fix that.

#12 Updated by Stéphane JOLY almost 2 years ago

Ulrich Pegelow wrote:

[...]

Yepp, that's the problem. Global tonemap should not go tiling with the drago operator. I'll gonna fix that.

Thank you so much ! :D

#13 Updated by Ulrich Pegelow almost 2 years ago

  • Status changed from In Progress to Fixed
  • % Done changed from 50 to 100

Thank you so much ! :D

Should be fixed now in master.

BTW: the fact that you see artifacts indicates that you have a low setting of preference parameter host memory limit (in MB) for tiling. Probably it's set to 500. For better performance on your 64-bit system you should set it to minimum 1500 or even higher (depending on your physical system memory).

#14 Updated by Stéphane JOLY almost 2 years ago

Ulrich Pegelow wrote:

Thank you so much ! :D

Should be fixed now in master.

BTW: the fact that you see artifacts indicates that you have a low setting of preference parameter host memory limit (in MB) for tiling. Probably it's set to 500. For better performance on your 64-bit system you should set it to minimum 1500 or even higher (depending on your physical system memory).

Thanks, I have increased memory in Darktable's preferences and the problem has gone. Thanks for helping me!

#15 Updated by Roman Lebedev almost 2 years ago

  • Target version set to 2.4.0

Also available in: Atom PDF