Project

General

Profile

Bug #11618

Copying over XMP data from a DNG makes exported image have no XMP at all

Added by Tobias Ellinghaus 2 months ago. Updated 2 months ago.

Status:
Fixed
Priority:
Low
Category:
General
Target version:
Start date:
05/17/2017
Due date:
% Done:

100%

Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

This started as an addendum to an old bug (#8513). As it's not really the same bug let's continue here.

The issue is that when exporting a Lightroom generated DNG with embedded XMP data the resulting JPEG has no XMP at all attached. When commenting out the part in exif.cc that copies over the original data then we have the dt XMP in the exported file at least.


Related issues

Copied from darktable - Bug #8513: tags from darktable aren't exported from RAW to jpg Fixed

Associated revisions

Revision d4312cd6
Added by Tobias Ellinghaus 2 months ago

Clear DerivedFrom from XMP before writing it

Lightroom doesn't just have a single string in that field but several.
Overwriting it with a string makes the XMP invalid and subsequently
exiv2 fails to write it.
Fixes #11618.

Revision 2a466300
Added by Tobias Ellinghaus 2 months ago

Clear DerivedFrom from XMP before writing it

Lightroom doesn't just have a single string in that field but several.
Overwriting it with a string makes the XMP invalid and subsequently
exiv2 fails to write it.
Fixes #11618.

(cherry picked from commit d4312cd6914470a1c60284aa3679afb3d6908a2a)

History

#1 Updated by Tobias Ellinghaus 2 months ago

  • Copied from Bug #8513: tags from darktable aren't exported from RAW to jpg added

#2 Updated by Tobias Ellinghaus 2 months ago

May I upload the DNG you sent me for others to have a look?

#3 Updated by Tobias Ellinghaus 2 months ago

I found a little more info: For some reason libexiv2 doesn't throw an exception when trying to write the XMP data to the image, however, when trying to encode it to a string manually it returns 3 which according to http://www.exiv2.org/doc/classExiv2_1_1XmpParser.html#afad88c80404f9f35b687b33fe9ea9c63 means "3 if the XMP toolkit failed and raised an XMP_Error". Time to investigate what is broken in there ...

#4 Updated by Tobias Ellinghaus 2 months ago

Sorry for all the noise. I think this is fixed. Please try and confirm so we can pick it to the stable branch.

#5 Updated by Tobias Ellinghaus 2 months ago

  • Status changed from Triaged to Fixed
  • % Done changed from 20 to 100

#6 Updated by Rolf Aalders 2 months ago

Sure Tobias, feel free up upload the files.

Sorry for the late response, I wasn't watching this issue.

#7 Updated by Roman Lebedev 2 months ago

  • Target version set to 2.4.0

Also available in: Atom PDF