Project

General

Profile

Bug #11616

Various ssues while trying to change keyboard shortcuts

Added by Matej Martinovic 2 months ago. Updated about 2 months ago.

Status:
Triaged
Priority:
Low
Assignee:
-
Category:
General
Target version:
-
Start date:
05/16/2017
Due date:
% Done:

20%

Affected Version:
2.2.4
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hello,

i'm experiencing various issues while trying to change the shortcuts for "next image" and "previous image" in the darkroom view. The default is on "backspace" and "space", my goal was the left and right arrow key. Following behavior:
  • Pressing the left arrow key (after double clicking on the existing shortcut) while the cursor is inside the settings window doesn't change the shortcut.
    The menu just jumps to the next settings tab on the left. When the mouse cursor is outside the window it might work, but i didn't manage it every time.
  • After the new shortcuts are set (multiple attempts) they don't work. Restarting darktable doesn't help.
  • Trying to change the shortcuts back only works after a few attempts, similiar behaviour as described above, possibly due to the location of the mouse cursor.

Working with 2.2.4 under Xubuntu 16.10 but using unity.

Thank you!
Cheers!
Matej

History

#1 Updated by Tobias Ellinghaus 2 months ago

  • % Done changed from 0 to 20
  • Status changed from New to Triaged

While not having issues assigning the arrow keys I can confirm that they don't work.
Theory: Maybe they are handled further up the event chain and not reaching the shortcuts?
This is on Debian/sid, running KDE on X11.

#2 Updated by Peter Budai about 2 months ago

I have looked into this.
It seems that if an accelerator map change is unsuccessful, there is no feedback to the user at all. You can see it here:
https://github.com/darktable-org/darktable/blob/master/src/gui/preferences.c#L919

Now I have experienced the same issue as Matej, but only sometimes: I press the left or right arrow key, and accelerator map update is just unsuccessful. Other times it works - really weird. So maybe it would be worthwile to have an error handling here.

Also I have noticed that setting an arrow accelerator for darkroom module is clearing the same accelerator for lightoom module (scroll left, scroll right) - is that intentional? All accelerators are working globally in all views?

#3 Updated by Tobias Ellinghaus about 2 months ago

(Configurable) keyboard shortcuts were added as a GSoC project, and the person that did that is no longer around. I fear that he was the only one knowing in depth how it all works. The rest of us might have some ideas but at least I would need to read the code to know for sure. :-(

Also available in: Atom PDF