Project

General

Profile

Bug #11586

Clone a module go to favorite modules

Added by Christian iuga 7 days ago. Updated 7 days ago.

Status:
Triaged
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
-
Start date:
04/21/2017
Due date:
% Done:

20%

Affected Version:
2.2.3
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

to reproduce the issue :
- Add a module into favorite (like shadow & higlight)
- Go into basic group
- Enable & tune the shadow & higligh module

Then when i duplicate this modules, the group change from basic to favorite

it's not a critical bug but it's strange & unexpected and it's also create a side effect :

if in favorite module, a module was expended before create the duplicate, i can see 2 modules expanded even with the option "expand a single darkroom module at a time" enable...

History

#1 Updated by Tobias Ellinghaus 7 days ago

  • % Done changed from 0 to 20
  • Status changed from New to Triaged

I won't have time to fix this myself. If anyone wants to give it a try, here is what's happening:

dt_dev_module_duplicate() calls dt_iop_load_module() which eventually calls dt_iop_load_module_by_so(). That function then calls dt_iop_gui_set_state() which is responsible for the tab changing. The quick hack would be to pass a flag down that call chain to not switch the module group. The better solution would be to think about why tab changing is part of module loading at all and maybe move that out of there – at the cost of making sure it's correctly called in all places where it's needed and not forgotten in the future.

Also available in: Atom PDF