Project

General

Profile

Bug #11584

src/win/rlimit.* is a NOP

Added by Pat David 6 months ago. Updated 6 months ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
General
Target version:
-
Start date:
04/20/2017
Due date:
% Done:

0%

Affected Version:
git master branch
System:
unknown
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Per LebedevRI, reporting this here. From a build by houz (darktable-2.3.0+563-g6ea20f75a-win64.exe).

Console reports, while starting:

```
[dt_set_rlimits_stack] info: bumping RLIMIT_STACK rlim_cur from 0 to 262144

(darktable.exe:1002036): Gtk-WARNING **: gtk_disable_setlocale() must be called before gtk_init()
[dt_pthread_create] info: bumping pthread's stacksize from 0 to 262144
[dt_pthread_create] info: bumping pthread's stacksize from 0 to 262144
[dt_pthread_create] info: bumping pthread's stacksize from 0 to 262144
[dt_pthread_create] info: bumping pthread's stacksize from 0 to 262144
```

Associated revisions

Revision 4d85cd98
Added by Roman Lebedev 6 months ago

win rlimit.c: default rlim_cur should be RLIM_INFINITY.

dt_set_rlimits_stack() is a NOP if it's unlimited, which
is what RLIM_INFINITY means. And since right now
this whole file is a NOP, it's better to assume that
defaults are unlimited, than printing msg as if we actually
bumped the limit.

Though, the proper fix, is to make this code to be non-NOP.

Refs #11584

History

#1 Updated by Roman Lebedev 6 months ago

  • Subject changed from Windows 10: Bumping RLIMIT_STACK to src/win/rlimit.* is a NOP

It probably would make sense to make it actually do something...

Also available in: Atom PDF