Project

General

Profile

Bug #11532

Different problems with masks in Darktable from master

Added by YAFU YAFU about 2 years ago. Updated about 2 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
-
Target version:
Start date:
03/05/2017
Due date:
% Done:

100%

Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

1- Impossible to select (get highlighted) the dotted line of mask when mouse over it, and the dotted line is very close to the drawing of the mask. While this is being solved, a hot key to select (highlight) the dotted line may be useful.

2- When you mouseover the little squares to drag the mask, they are not highlighted when the mouse pointer is located exactly on them (it is somewhat shifted)

3- When you draw a mask of very small size, it is automatically finished/terminated approximately to the third or fourth mark (click).

I have tried compiling Darktable in Kubuntu 14.04, 16.04 and Ubuntu 16.04, and this always happens from Master. The problem does not occur in Darktable 2.0.7 from PPA. Here you can see the comparison in the videos:

From master (broken)
https://www.dropbox.com/s/jr6i5g31f1cbqi9/darktable_mask_Master-2017-03-05.mkv?dl=0

2.0.7:
https://www.dropbox.com/s/9b5t0e13i3oi8hc/darktable_mask_2.0.7-2017-03-05.mkv?dl=0

History

#1 Updated by Ulrich Pegelow about 2 years ago

  • Status changed from New to Confirmed
  • % Done changed from 0 to 10
  • System changed from Ubuntu to all

Your point number (3) really indicates an issue. I'll have to look up why small shapes are terminated with only three nodes.

Concerning (2): looks like a minor UI glitch. Even not sure if it has been designed by intention to make it easier moving the square without touching the node nearby.

About (1): There has been a change between 2.0 and 2.2 when it comes to changing the feathering size of a mask (depicted by a dotted line). People found it hard to make any changes onces the size of the feathering area was close to zero. The feathering size is now changed by shift-scroll while your mouse is anywhere over the shape.

#2 Updated by YAFU YAFU about 2 years ago

About (2), I see that the problem occurs mainly when the drawing of the mask and the feathering dotted line are very close. Perhaps it has been designed that way. But I do not know, it's a bit confusing that this is not highlighted when the mouse pointer is exactly over it.

About (1), oh, I had not noticed that it is now possible to change feathering size with Shift + Scroll. That's good, thank you.

#3 Updated by Ulrich Pegelow about 2 years ago

Coming back to (3): this is an (undocumented) feature that's in the masks code from the beginning. The idea is to automatically close a path if the last point is set close to the starting point, indicated by the starting point being highlighted. This works with any path size but obviously is more likely to happen accidentally if the shape is very small.

The question is now what to do. The current behavior is not new and other users might use it to their advantage. I am hesitating to just simply removing that feature...

#4 Updated by Ulrich Pegelow about 2 years ago

Issue (2) has been addressed by having a stricter limit on closeness.

#5 Updated by Ulrich Pegelow about 2 years ago

  • Status changed from Confirmed to Fixed
  • % Done changed from 10 to 100

#6 Updated by Roman Lebedev about 2 years ago

  • Target version set to 2.4.0

Also available in: Atom PDF