Project

General

Profile

Bug #11436

build.sh --skip-build fails since commit b82d189e00a8741cd1fce5207f60814c1959cc7f

Added by Yves Deweerdt over 2 years ago. Updated over 2 years ago.

Status:
Closed: won't fix
Priority:
Low
Assignee:
-
Category:
Buildsystem
Target version:
Start date:
01/06/2017
Due date:
% Done:

0%

Affected Version:
git master branch
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

~darktable$ git bisect start master release-2.3.0
~darktable$ git bisect run ./build.sh --skip-build
~darktable$ git bisect log
  1. bad: [bcd22673e868a5386f5ec44fdbafd9c5044212fa] Merge pull request #1367 from upegelow/mask_free_fix
  2. good: [e9c6243371087d04848b7686888f6dd29dfaef0e] Revert "release: temporarily remove unfinished translations"
    git bisect start 'master' 'release-2.3.0'
  3. good: [42c05ada5000c409ff75ee0a4266938f2bc883eb] local laplacian: max out pyramid depth, better shadow/highlight results
    git bisect good 42c05ada5000c409ff75ee0a4266938f2bc883eb
  4. good: [8d54e7021b11d3c57aaa031b88c5f72b6d13ccb0] Update French translation.
    git bisect good 8d54e7021b11d3c57aaa031b88c5f72b6d13ccb0
  5. bad: [510a1158e978deb4a3c89c9505181cba34a3d2fb] local laplacian: shield remaining two omp pragmas
    git bisect bad 510a1158e978deb4a3c89c9505181cba34a3d2fb
  6. good: [693ae87b4dfd0c291969e2043c606935bf55fca5] Merge remote-tracking branch 'origin/master' into monochrome
    git bisect good 693ae87b4dfd0c291969e2043c606935bf55fca5
  7. bad: [3f6bef261e1edee30e4c391932f2dbf3912489d6] Merge remote-tracking branch 'origin/master' into monochrome
    git bisect bad 3f6bef261e1edee30e4c391932f2dbf3912489d6
  8. bad: [3b4c49d16b859758ddeccdf8a261719ac3f0c5f9] Track rawspeed as submodule
    git bisect bad 3b4c49d16b859758ddeccdf8a261719ac3f0c5f9
  9. bad: [b82d189e00a8741cd1fce5207f60814c1959cc7f] Purge bundled rawspeed
    git bisect bad b82d189e00a8741cd1fce5207f60814c1959cc7f
  10. first bad commit: [b82d189e00a8741cd1fce5207f60814c1959cc7f] Purge bundled rawspeed

History

#1 Updated by Roman Lebedev over 2 years ago

  • Status changed from New to Closed: won't fix

rawspeed is now a submodule.
after check-out of some revision of darktable repo, you now need to run

$ git submodule update

I don't think it's a job for build.sh

#2 Updated by Yves Deweerdt over 2 years ago

I won't go in disussion about it being a job for build.sh or not.
If you choose not to put it in the build.sh however, I would like to recommend putting it in the README.md that you need to do git submodule update --init before starting the build.

#3 Updated by Roman Lebedev over 2 years ago

Some basic information about submodule has been added.

#4 Updated by Roman Lebedev over 2 years ago

  • Target version set to 2.4.0

Also available in: Atom PDF