Project

General

Profile

Bug #11422

removing tags takes a long time

Added by David Schaefer over 2 years ago. Updated over 2 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
-
Target version:
Start date:
01/03/2017
Due date:
% Done:

100%

Affected Version:
git master branch
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi,

I have 2844 files selected. I want to remove 1 tag. dt istantly reports 2 photos are using that tag, whether I am sure. When clicking YES dt takes very long time (ca 5 minutes) to execute that action.

From the duration I assume it opens each file and checks for that tag - even if the knowledge about the 2 photos having this tag is already there.

Associated revisions

Revision c2531ba4
Added by Tobias Ellinghaus over 2 years ago

Fix #11422: Don't write all XMP when detaching tag

Revision dee11008
Added by Tobias Ellinghaus over 2 years ago

Fix #11422: Don't write all XMP when detaching tag

(cherry picked from commit c2531ba49e076dc118a6bff36322a29e2190be0c)

History

#1 Updated by Tobias Ellinghaus over 2 years ago

  • Status changed from New to Incomplete
  • % Done changed from 0 to 20

What do you mean with "removing tags"? Deleting the tag entirely from darktable or detaching it from the images? I assume the latter? Looking at the code it seems to have the potential of being terribly slow indeed as it writes the XMP of all selected files, even when it wasn't affected.

#2 Updated by Tobias Ellinghaus over 2 years ago

  • Status changed from Incomplete to Fixed
  • % Done changed from 20 to 100

#3 Updated by Tobias Ellinghaus over 2 years ago

Please test if your problem is fixed.

#4 Updated by David Schaefer over 2 years ago

Tested several times and the general issue is fixed. Thank you.

It still was slow in the following situation:

1 - using dt to read in image Ia in place Pa
2 - moving Ia to place Pb outside of dt
3 - using dt to read in image Ia in place Pb
(now we have 2 references to 1 image, one reference is dead)
4 - When I now select 2000 images and remove one of the tags from Ia it again takes several minutes.

#5 Updated by Tobias Ellinghaus over 2 years ago

Is it also slow when you don't add the image in the new place to dt? I.e. if you just have one image in the library which is missing on disk.

#6 Updated by David Schaefer over 2 years ago

Its very snappy when one image is missing, even when having 2K images selected.

#7 Updated by Tobias Ellinghaus over 2 years ago

Then I don't understand why it's becoming slow when adding the image in another location again. darktable doesn't know that it's the same file and doesn't care. So the only difference is that in the slow case you added one more image to the library.

#8 Updated by David Schaefer over 2 years ago

I was testing the fast case several times. I've only experienced the slow one once. Tonight I will test for the slow case to see if I still can reproduce that behavior.

#9 Updated by David Schaefer over 2 years ago

tested again. All fine. Thanks.

#10 Updated by Roman Lebedev over 2 years ago

  • Target version set to 2.4.0

Also available in: Atom PDF