Project

General

Profile

Bug #11421

Unnecessary xmp write on read

Added by David Schaefer over 2 years ago. Updated over 2 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
-
Target version:
Start date:
01/03/2017
Due date:
% Done:

100%

Affected Version:
git master branch
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi,

I have a huge collection of files on my NFS server and use that from 2 different computers. Whenever I start one darktable instance all xmp files are scanned for change (I have explicitly turned on this feature in the settings to be able to work from 2 computers on the same database). The problem is that for each xmp file the xmp timestamp is updated and such darktable hangs a while, then presents me a UI "updated xmp sidecar files found", I check them all (since I dont know which file has been changed), and then darktable hangs for several minutes.

Right now I was able to file this bugreport while dt was reading in the updated xmp sidecar files.

Associated revisions

Revision 235209e6
Added by Tobias Ellinghaus over 2 years ago

Don't write XMP when they didn't change

When the XMP already exists on disk then we hash it first, compare that
hash to the final data we are about to write and skip writing if the
hashes match. Unfortunately the hashes can't be cached in db as one
major use case is using the same images with several dbs or changing the
XMPs from the outside.
Fixes #11421

History

#1 Updated by Tobias Ellinghaus over 2 years ago

  • % Done changed from 0 to 50
  • Status changed from New to In Progress

The problem seems to be that at import the XMPs are rewritten, so when using two libraries every sidecar seems to be changed.

#2 Updated by Tobias Ellinghaus over 2 years ago

  • % Done changed from 50 to 100
  • Status changed from In Progress to Fixed

#3 Updated by David Schaefer over 2 years ago

This fixes my issue perfectly! Thank you very much!

#4 Updated by Roman Lebedev over 2 years ago

  • Target version set to 2.4.0

Also available in: Atom PDF