Project

General

Profile

Bug #11419

liquify: cusp mode not always working for curves

Added by Matthieu Moy over 2 years ago. Updated over 2 years ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
Darkroom
Target version:
Start date:
01/02/2017
Due date:
% Done:

100%

Affected Version:
git master branch
System:
Debian
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi again,

The modes to control the bezier curve (autosmooth, cusp, smooth, symmetrical) do not always work as expected.

Steps to reproduce:

  • Create a 3-points curve using the liquify tool
  • Control-click the second point (i.e. the one in the middle). The control point turns into a triangle, and bezier controls appear as expected (cusp mode).
  • Move the bezier handle on the right hand side of the node

Expected:

Moving one handle does not move the other, since we're in cusp mode.

Actual:

Moving one handle moves the other (direction + amplitude), as in the symmetrical mode.

Moving the one on the left hand side just doesn't work (the point doesn't move at all).

The expected behavior is restored if one changes the mode of neighboring nodes, or more precisely of the previous node in the curve: if the first and second nodes have cusp mode, it works as expected.

Anyway, thanks for such great tool, and keep the good work!

Associated revisions

Revision 75c05f21
Added by Pascal Obry over 2 years ago

Fix liquify handle where it was not possible to move one control point.

Given a curve with 3 points:

S ------------> C ------------------ S
^
o-----------o
1 2
S    : Auto-Smooth point
C : Cusp point
1, 2 : are the two control points

It was possible to move 1 but not 2. This was just a missing case in
the smootyhing of the path.

Closes #11419

Revision 801a64e7
Added by Pascal Obry about 2 years ago

Fix liquify handle where it was not possible to move one control point.

Given a curve with 3 points:

S ------------> C ------------------ S
^
o-----------o
1 2
S    : Auto-Smooth point
C : Cusp point
1, 2 : are the two control points

It was possible to move 1 but not 2. This was just a missing case in
the smootyhing of the path.

Closes #11419

(cherry picked from commit 75c05f21022cfb1a7d1581f6a83641e977c2cf92)

History

#1 Updated by Pascal Obry over 2 years ago

  • Assignee set to Pascal Obry

#2 Updated by Pascal Obry over 2 years ago

  • % Done changed from 0 to 100
  • Target version set to 2.4.0
  • Status changed from New to Fixed

That was not easy to understand where the issue was but this is now fixed on master.

Also available in: Atom PDF