Project

General

Profile

Bug #11395

raw overexpose erroneously covers frame when changing wb

Added by Mark Oteiza over 2 years ago. Updated over 2 years ago.

Status:
Fixed
Priority:
Medium
Assignee:
Category:
Darkroom
Target version:
Start date:
12/27/2016
Due date:
% Done:

100%

Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi,

When changing white balance on an image, raw overexposure reports all channels clipped over the entire frame.

I'm linking (and attaching) screenshots.
https://a.pomf.cat/fpcpzq.png
https://a.pomf.cat/efxyyw.png

before.png (1.25 MB) Mark Oteiza, 12/27/2016 06:02 PM

after.png (210 KB) Mark Oteiza, 12/27/2016 06:02 PM

Associated revisions

Revision b46fc9c5
Added by Roman Lebedev over 2 years ago

Rawoverexposed iop: don't go mad because of missing data. Fixes #11395

Wb presets contain 4 values, with the last one being 0.0,
for all current cases. It would be non-0.0 for 4BAYER
camera. And the module did not know that last 0.0
was not important for a given image, so it displayed whole
image as overexposed.

Fixing it by only using first 3 multipliers for normal non-4BAYER
cameras fixes it.

Even though, this module does not support 4BAYER images currently.

Revision 1b5fa202
Added by Roman Lebedev over 2 years ago

Rawoverexposed iop: don't go mad because of missing data. Fixes #11395

Wb presets contain 4 values, with the last one being 0.0,
for all current cases. It would be non-0.0 for 4BAYER
camera. And the module did not know that last 0.0
was not important for a given image, so it displayed whole
image as overexposed.

Fixing it by only using first 3 multipliers for normal non-4BAYER
cameras fixes it.

Even though, this module does not support 4BAYER images currently.

(cherry picked from commit b46fc9c5e67fd88e8f0d900d161345a1585a633e)

History

#1 Updated by Roman Lebedev over 2 years ago

  • Status changed from New to Confirmed
  • % Done changed from 0 to 10
  • Priority changed from Low to Medium
  • Assignee set to Roman Lebedev
  • System changed from other GNU/Linux to all

happens if i select any camera wb preset

#2 Updated by Roman Lebedev over 2 years ago

  • % Done changed from 10 to 100
  • Status changed from Confirmed to Fixed

#3 Updated by Roman Lebedev over 2 years ago

  • Target version set to 2.4.0

Also available in: Atom PDF