Project

General

Profile

Bug #11393

Numerical input for sliders not working

Added by Ulrich Kiermayr over 2 years ago. Updated over 2 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
12/26/2016
Due date:
% Done:

100%

Affected Version:
2.2.0
System:
Mac OS X
bitness:
64-bit
hardware architecture:
amd64/x86

Description

The numerical input for sliders in darkroom is not working.


Related issues

Duplicated by darktable - Bug #11430: Sliders in darkroom modules don't respond to keyboard input, but change image rating Duplicate 01/04/2017

Associated revisions

Revision c2e30fb3
Added by Christian Stussak over 2 years ago

slider popup: grab only keyboard events, fixes #11393

After the introduction of a separate code path for GTK 3.20+, numerical input for sliders was broken on some platforms that used this code path. The old code path just grabbed for keyboard events, while the GTK 3.20+ code path grabbed all kinds of events. This commit adjusts the GTK 3.20+ code accordingly. Only keyboard events are grabbed and owner_events is set to FALSE. This fixes problems with numerical input to the slider popup on macOS and possibly other platforms where GTK 3.20+ is used.

Revision e228f587
Added by Roman Lebedev over 2 years ago

Merge remote-tracking branch 'upstream/pr/1413'

  • upstream/pr/1413:
    slider popup: grab only keyboard events, fixes #11393

Revision 7838578a
Added by Christian Stussak over 2 years ago

slider popup: grab only keyboard events, fixes #11393

After the introduction of a separate code path for GTK 3.20+, numerical input for sliders was broken on some platforms that used this code path. The old code path just grabbed for keyboard events, while the GTK 3.20+ code path grabbed all kinds of events. This commit adjusts the GTK 3.20+ code accordingly. Only keyboard events are grabbed and owner_events is set to FALSE. This fixes problems with numerical input to the slider popup on macOS and possibly other platforms where GTK 3.20+ is used.

(cherry picked from commit c2e30fb3290f4037f8cb7e739511321e3b44286f)

History

#1 Updated by Tobias Ellinghaus over 2 years ago

Could you be a bit more precise? What isn't working? Can't you enter values? Does dt ignore them? What version of OSX? Did you use the DMG or compile yourself?

#2 Updated by Ulrich Kiermayr over 2 years ago

Hello,

I can't enter the values. No matter what number I type on the keyboard - nothing happens.

I am running the dmg for 2.2.0 from the website on MacOS X 10.11.5

lG Ulrich

#3 Updated by Roman Lebedev over 2 years ago

I think parafin said that this bug is still remaining, and is probably a gtk issue.

My guess is: Closed: upstream...

#4 Updated by Roman Lebedev over 2 years ago

  • Duplicated by Bug #11430: Sliders in darkroom modules don't respond to keyboard input, but change image rating added

#5 Updated by Christian Stussak over 2 years ago

Do you really think this is a GTK issue? It is not that nothing happens when you type digits on the keyboard. The digits just affect the wrong component, no? They go into the film strip at the bottom of the darkroom and affect the star rating instead.

Is is possible to figure out where keyboard events actually go in GTK?

#6 Updated by Roman Lebedev over 2 years ago

Christian Stussak wrote:

Do you really think this is a GTK issue?

I do.

It is not that nothing happens when you type digits on the keyboard. The digits just affect the wrong component, no? They go into the film strip at the bottom of the darkroom and affect the star rating instead.

Is is possible to figure out where keyboard events actually go in GTK?

Be sure to send patches if you figure out what's wrong :)

#7 Updated by Christian Stussak over 2 years ago

Personally, I find this bug very annoying and I can imagine to put more time into its analysis. Can you at least point me to the files worth looking at? Is this popup thing of the slider a gtk component or within darktables codebase?

#8 Updated by Christian Stussak over 2 years ago

I put a couple of hours into it. Actually, quite a few (I spent most of the time building darktable on macOS via homebrew such that it doesn't SEGFAULT, but that's unrelated to this issue).

It is d4f79bba3409c3b218faedd7deb95b224fb8b4ba that breaks keyboard support for slider popups. The changed code belongs to a change in gtk 3.20. If I revert this commit, keyboard works again, but mouse support is broken. The pre-3.20 codepath works fine for both, also on 3.20+ (but it is deprecated).

I don't have a solution yet. Maybe it actually is a gtk issue. But my knowledge about darktable and gtk is too small to tell.

Also, I found this: https://bugzilla.gnome.org/show_bug.cgi?id=765219
Same line of code, but different problem.

#10 Updated by Heiko Bauke over 2 years ago

Recently, I become aware of a small bug in the tethering mode of darktable versions 2.2.0 and 2.2.1 that is related (or even identical) to the bug described above.

It is not possible to enter the figures 0 to 5 into the numerical fields of the camera control panel as soon as at least one picture has been taken in a capture job. Hitting the keys 0, 1, 2, 3, 4, or 5 changes the rating of a picture instead of the values for “timer(s)”, “count”, “brackets”, or “bkt. steps” even if the input seem to have the focus. Keys 6 to 9, however, work as expected. I experienced this kind of bug only in the tethering mode so far. I am running darktable on Ubuntu 16.10.

#11 Updated by Christian Stussak over 2 years ago

My first fix was actually more a workaround. This should do it: https://github.com/darktable-org/darktable/pull/1413.

#12 Updated by Christian Stussak over 2 years ago

I don't think this bug is related to anything in tethering mode. It is very specific to the slider popup. Also, for the slider, keyboard input does not work at all. It's not just 0,...,5 being broken. Keys 6, 7, 8, 9 don't work as well.

Someone else has to check if these two issues are related. I can't test it. My cam is not supported in tethering mode.

#13 Updated by Anonymous over 2 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

#14 Updated by Christian Stussak over 2 years ago

@Heike Bauke: Looks like you have to open a new ticket if you want the tethering issue to be fixed.

#15 Updated by Roman Lebedev over 2 years ago

  • Target version set to 2.4.0

Also available in: Atom PDF