Project

General

Profile

Bug #11373

undo exception - possibly on reaching the first item in the undo queue

Added by David Schaefer over 2 years ago. Updated over 2 years ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
Darkroom
Target version:
Start date:
12/19/2016
Due date:
% Done:

100%

Affected Version:
git master branch
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Associated revisions

Revision af461c14
Added by Pascal Obry over 2 years ago

When entering the darkroom always clean-up the undo list.

We remove the DT_UNDO_HISTORY from the list when entering the darkroom as
we want to start with a clean undo list.

Closes #11265.
Closes #11373.

Revision 554ccc35
Added by Pascal Obry over 2 years ago

When entering the darkroom always clean-up the undo list.

We remove the DT_UNDO_HISTORY from the list when entering the darkroom as
we want to start with a clean undo list.

Closes #11265.
Closes #11373.

(cherry picked from commit af461c14183cccb294c586e4c132a7a582d82e1a)

History

#1 Updated by Pascal Obry over 2 years ago

  • Assignee set to Pascal Obry

I don't think this is because reaching the first item. At least it has been tested in this case.

Better than just sending a backtrace (which is helpful) is also to give a reproducer. Do you remember what you've been doing? A specific module? Many undo and redo? Just undo?

#2 Updated by David Schaefer over 2 years ago

Unfortunately not. Is the adresssanitizer output enough or do you still favor me trying to remember what I did?

#3 Updated by Stefan Schöfegger over 2 years ago

I can reproduce it very fast. Open crop module press CTRL+Z and do a few double clicks and press CTRL+Z again when in darkroom -> crash or hang

#4 Updated by Pascal Obry over 2 years ago

Should now be fixed.

#5 Updated by Pascal Obry over 2 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100
  • Target version set to Candidate for next patch release

#6 Updated by Pascal Obry over 2 years ago

  • Category set to Darkroom

#7 Updated by Roman Lebedev over 2 years ago

  • Target version changed from Candidate for next patch release to 2.4.0

Also available in: Atom PDF