Project

General

Profile

Bug #11364

consistent wording: dt_lua_image_t.delete() implements function otherwise referred to as "remove"

Added by Richard Wonka about 1 year ago. Updated about 1 year ago.

Status:
New
Priority:
Low
Category:
Lua
Target version:
-
Start date:
12/14/2016
Due date:
% Done:

0%

Affected Version:
2.0.7
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

It would be easier for beginners (like me) to see consistent wording for functionality.

I suggest adding dt_lua_image_t.remove() or renaming dt_lua_image_t.delete() to dt_lua_image_t.remove() before more lua code is written.

History

#1 Updated by Tobias Ellinghaus about 1 year ago

I agree that the current naming is inconsistent with the rest of darktable. However, changing that now is impossible.

#2 Updated by Richard Wonka about 1 year ago

"Impossible" seems a big word. Would "unpleasantly tedious" describe the situation? :-)

I think this issue will create a lot of work in FAQs, forums, README's and unhappy users.

The effort/overhead of changing it now might well be less than the sum of future unpleasantness.

Also: how about adding a "remove()" that does the same thing? Simpler to implement and won't break the current API...

#3 Updated by Tobias Ellinghaus about 1 year ago

No, "impossible" is the right word. If we changed "delete" to actually delete the files from disk now then all the scripts out there that use that function to remove images from the db (which is what it currently does) would suddenly start deleting files. Which is completely out of question. Like, not even worth discussing.

Also available in: Atom PDF