Project

General

Profile

Feature #11352

osx dmg does not contain lensfun-update-data

Added by Alexander Gruber over 2 years ago. Updated over 2 years ago.

Status:
Closed: upstream
Priority:
Low
Assignee:
-
Category:
General
Target version:
Start date:
12/08/2016
Due date:
% Done:

0%

Affected Version:
git master branch
System:
Mac OS X
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Lensfun has not released a new release since over a year. E.g. on macOS the lensfun db included through macports is therefor still from 11/2015. As the lensfun db is updated quiet often they created an update mechanism to deal with that. It would be great if this could be integrated into darktable to be more independent from lensfun releases and always include the latest lenses.

The tool is described here: http://lensfun.sourceforge.net/manual/lensfun-update-data.html

The code is here: https://sourceforge.net/p/lensfun/code/ci/master/tree/apps/lensfun-update-data

History

#1 Updated by Roman Lebedev over 2 years ago

Alexander Gruber wrote:

Lensfun has not released a new release since over a year. E.g. on macOS the lensfun db included through macports is therefor still from 11/2015. As the lensfun db is updated quiet often they created an update mechanism to deal with that. It would be great if this could be integrated into darktable to be more independent from lensfun releases and always include the latest lenses.

The tool is described here: http://lensfun.sourceforge.net/manual/lensfun-update-data.html
The code is here: https://sourceforge.net/p/lensfun/code/ci/master/tree/apps/lensfun-update-data

Is it not being installed by the lensfun package from macports?
That tool is supposed to be run by user, i'm not sure darktable should care..

#2 Updated by Roman Lebedev over 2 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Incomplete

#3 Updated by Alexander Gruber over 2 years ago

Roman Lebedev wrote:

Is it not being installed by the lensfun package from macports?
That tool is supposed to be run by user, i'm not sure darktable should care..

It does not seem so:

jupiter:darktable.app alex$ find . -name lensfun*
./Contents/Resources/share/lensfun

I also doubt that many users will find the script on their Linux systems and run it manually either. I'm aware that this is of course something that should usually be separated from darktable as it is part of lensfun. But as I guess many users are using the lens correction module and new lenses come out very often I think it might be a good idea to include something for that. Just imho. :-)

#4 Updated by Alexander Gruber over 2 years ago

I'm just talking about the dmg available from github by the way. If you install the whole build environment via macports it is of course present in macOS. So maybe the version "master branch" is not correct?!

#5 Updated by Roman Lebedev over 2 years ago

Alexander Gruber wrote:

Roman Lebedev wrote:

Is it not being installed by the lensfun package from macports?
That tool is supposed to be run by user, i'm not sure darktable should care..

It does not seem so:

jupiter:darktable.app alex$ find . -name lensfun*
./Contents/Resources/share/lensfun

Well, if that script is part of that lensfun release, then i guess you need to bug macports to install it...

I also doubt that many users will find the script on their Linux systems and run it manually either. I'm aware that this is of course something that should usually be separated from darktable as it is part of lensfun. But as I guess many users are using the lens correction module and new lenses come out very often I think it might be a good idea to include something for that. Just imho. :-)

darktable simply uses lensfun for lens corrections. darktable does not know whether the lensfun takes it's data from /dev/urandom, built-in into liblensfun.so, or run-time loads it from xml's.
if the lensfun that is available on end-users machines is outdated, it's then it's a problem between that script, the lensfun provided by distribution and user.

#6 Updated by Roman Lebedev over 2 years ago

  • Subject changed from Implement lensfun db update mechanism to osx dmg does not contain lensfun-update-data
  • System changed from all to Mac OS X
  • Assignee set to Igor Kuzmin

Alexander Gruber wrote:

I'm just talking about the dmg available from github by the way. If you install the whole build environment via macports it is of course present in macOS. So maybe the version "master branch" is not correct?!

[22:12:54] <LebedevRI> parafin: which lensfun is in our dmg's? is lensfun-update-data tool included?
[22:17:52] <parafin> LebedevRI, latest release
[22:18:03] <parafin> tool - probably no

#7 Updated by Roman Lebedev over 2 years ago

  • Status changed from Incomplete to Closed: upstream
  • Assignee deleted (Igor Kuzmin)
  • % Done changed from 20 to 0

https://github.com/macports/macports-ports/blob/master/graphics/lensfun/Portfile#L42-L43

[22:26:47] <parafin> yeah, ok, macOS only includes python-2.x
[22:26:59] <parafin> I'm not interested in packaging python into DT bundle
[22:27:31] <parafin> so for me it's "won't fix"

#8 Updated by Roman Lebedev over 2 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF