Project

General

Profile

Bug #11324

New function "Hint" kills Icon functionality in Docky

Added by Joe Giampaoli over 3 years ago. Updated about 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
General
Target version:
Start date:
11/21/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.2.0rc0
System:
Debian
bitness:
64-bit
hardware architecture:
amd64/x86

Description

In xfce with docky when DT hints that images have been imported or exported successfully the DT icon on my docky will not let me minimize, therefore I have to minimize from the window manager in DT, then after that the icon in Docky minimizes as it should.

Don't know if this affects other type of launchers like standard xfce panel or on other window managers. I understand that this function might still be a work in progress, just wanted to demonstrate what happens in my case.

This happens both when importing and exporting and the icon flashes red.

Affects both Debian and Xubuntu.

Attaching screencap for clearer understanding.

Thanks!

0001-0565.mp4 (6.38 MB) 0001-0565.mp4 Joe Giampaoli, 11/21/2016 02:43 AM

Associated revisions

Revision 4f02038b (diff)
Added by Tobias Ellinghaus over 3 years ago

Only hint using window manager when dt not active

This is related to bug #11324.

History

#1 Updated by Roman Lebedev over 3 years ago

https://github.com/darktable-org/darktable/commit/984c3e7b47f9bcf9643ab6c8eb1ca2cf0cff66cb

commit 984c3e7b47f9bcf9643ab6c8eb1ca2cf0cff66cb
Author: Tobias Ellinghaus <me@houz.org>
Date:   Wed Oct 5 13:09:08 2016 +0200

    Notify user when import/export is done

    Tell the window manager to draw the user's attention to dt when an
    import of a folder or an export is finished. Those two can take a long
    time to be processed so the user might want to do something else outside
    of dt in the meantime. Instead of listening to the CPU fan slowing down
    as an indication he will now be told by his window manager/desktop
    environment. On KDE for example the entry in the taskbar is highlighted.

I'd guess this is an upstream issue?

#2 Updated by Tobias Ellinghaus over 3 years ago

Sounds like a bug in your XFCE thing. What happens when other programs hint the window manager? For example XChat/Hexchat does it when your name was seen in a chat.

#3 Updated by Joe Giampaoli over 3 years ago

Are you on IRC right now? Maybe we can test?

#4 Updated by Joe Giampaoli over 3 years ago

OK, so a quick follow-up:

Strangely if Darktable is minimized and I receive the hint in Docky and click on the launcher DT maximizes without issues. This makes me think that when we tested in IRC with Xchat, I had Xchat minimized so it had no issues. I would have to test with a maximized program, or maybe you have to see if you can somehow override the hint when DT is maximized. Can you do that? Is it possible? I think Xchat doesn't hint when maximized.

How can I test with a script or something to hint anything when maximized?

#5 Updated by Joe Giampaoli over 3 years ago

Of course Xchat doesn't hint when maximized, I just saw how dumb of me thinking it would... :)

#6 Updated by Joe Giampaoli over 3 years ago

So yeah, you have to disable the hint when maximized...

#7 Updated by Roman Lebedev over 3 years ago

Joe Giampaoli wrote:

Of course Xchat doesn't hint when maximized, I just saw how dumb of me thinking it would... :)

Hexchat and xchat are using gtk-2.
It would be better to test on something that is using gtk-3, like dt.

#8 Updated by Tobias Ellinghaus over 3 years ago

Of course XChat hints when maximized. Where do you see it not hinting? Just give focus to some other window.

Roman: We are using XChat to find out if it's a general problem of XFCE or a dt issue. If you know any other GTK3 programs using window manager hints we should use those of course.

#9 Updated by Joe Giampaoli over 3 years ago

Actually with Roman's comment that gave me an idea, I did that test. I imported and before it finished importing or before hinting I switched quickly to a terminal window to put it on focus and waited for DT's hint, when it hinted I clicked on DT icon which obviously switched to that window and minimize worked, so this is mostly when the DT window is in focus.

#10 Updated by Joe Giampaoli over 3 years ago

Let me check what have I compiled with gtk3, I think audacious, not sure....

#11 Updated by Joe Giampaoli over 3 years ago

Audacious has no hinting, it's OK, we'll figure something out, it's not that critical, just awkward...

#12 Updated by Joe Giampaoli over 3 years ago

Hey, wait a sec...

Can you disable the hinting in the code for when DT has focus? Or is the hinting with focus actually happening because of a GTK3 bug from my side? For example, does it hint for you when it has focus?

#13 Updated by Joe Giampaoli about 3 years ago

This bug is fixed in 2.2.0-rc2

I guess you did disable the hinting when DT had focus? It hints nicely when minimized or another window has focus and nothing when active.

Thank you so much!

#14 Updated by Tobias Ellinghaus about 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

Thanks for confirming the fix.

#15 Updated by Roman Lebedev about 3 years ago

  • Target version changed from Future to 2.2.0

Also available in: Atom PDF

Go to top