Project

General

Profile

Bug #11306

Old XMP's are silently discarded, thus breaking any backward compatibility.

Added by Stefan Schöfegger over 3 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Critical
Category:
-
Target version:
Start date:
11/12/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.2.0rc0
System:
Debian
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Noise profile with dartable-cli of 2.2.0rc0 does produce different histogram than in 2.0.7 (Version of debian stretch), profile can't be calculates with 2.2.0rc0 {{{
$\033[31mERROR: Incorrect green channel.

Possible reason:
o The input RAW image is bad regarding lighting or exposure.
o You may have set a default output profile in darktable which is
unsuitable for noise profiling.
}}}

I always used the tools from 2.2.0rc0 to create the profile

DSC06779_2.2.0rc0.pdf (46.7 KB) DSC06779_2.2.0rc0.pdf does not work Stefan Schöfegger, 11/12/2016 02:10 PM
DSC06779_2.0.7.pdf (52.1 KB) DSC06779_2.0.7.pdf ok Stefan Schöfegger, 11/12/2016 02:10 PM
DSC06779.ARW (15.8 MB) DSC06779.ARW Stefan Schöfegger, 11/12/2016 02:14 PM
noise_result_00e9652_reverted_f51f5db.pdf (52.1 KB) noise_result_00e9652_reverted_f51f5db.pdf Stefan Schöfegger, 11/12/2016 07:31 PM
kaputt.patch (1.97 KB) kaputt.patch Johannes Hanika, 11/12/2016 10:50 PM
old-broken.xmp (10.5 KB) old-broken.xmp Johannes Hanika, 11/12/2016 10:52 PM
DSC_2051.NEF.xmp (4.03 KB) DSC_2051.NEF.xmp Fabrice 81, 11/13/2016 12:23 AM
DSC_2052.NEF.xmp (4.03 KB) DSC_2052.NEF.xmp Fabrice 81, 11/13/2016 12:46 AM
DSC_2055.NEF.xmp (5.42 KB) DSC_2055.NEF.xmp File xmp from Nikon D50 edited with DT 1.4 Fabrice 81, 11/13/2016 02:03 AM

History

#1 Updated by Roman Lebedev over 3 years ago

  • % Done changed from 0 to 10
  • Priority changed from Low to Critical
  • Assignee set to Tobias Ellinghaus
  • Status changed from New to Confirmed
  • Subject changed from Noise profiling does not work to Old XMP's are silently discarded, thus breaking any backward compatibility.

#2 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

#3 Updated by Stefan Schöfegger over 3 years ago

reverted f51f5db gives the same histogram but a little but different resulting curve.

#4 Updated by Roman Lebedev over 3 years ago

In the mean time i have reverted f51f5db, for now.

#5 Updated by Johannes Hanika over 3 years ago

for what it's worth, with this little patch i can load the old xmp file again.

in short, back when we wrote xmp like this, everything was in <rdf:Bag>, not <rdf:Seq>. very much unsure about the implications of this, i think we'd need to run this function twice. once with the Seq and if that fails retry with the Bag variant? please note the patch is just a demonstration and very much incomplete.

i'm attaching old-broken.xmp for reference and easier reproduction, too.

also i don't think we need roman's revert to solve this. probably this pugi xml code path was always broken for these really ancient xmp files?

#6 Updated by Johannes Hanika over 3 years ago

see 691fd85

please review and test thoroughly, this is like the one thing we don't want broken..

#7 Updated by Fabrice 81 over 3 years ago

2.2.0rc0+76~g691fd85 still not working

here is my file from a Nikon D50 photo, edited with DT 1.4 without modification in Darkroom, well understood by 2.0.7 but not by 2.2.0rc0+76~g691fd85

#8 Updated by Fabrice 81 over 3 years ago

2.2.0rc0+76~g691fd85 still not working

here is my file from a Nikon D50 photo, edited with DT 1.4 with little modifications, well understood by 2.0.7 but not by 2.2.0rc0+76~g691fd85

#9 Updated by Fabrice 81 over 3 years ago

Errata

Sorry, after having erased my whole .config/darktable/ directory, and working on a new shot, 2.2.0rc0+76~g691fd85 works fine.

#10 Updated by Tobias Ellinghaus over 3 years ago

  • % Done changed from 10 to 100
  • Status changed from Confirmed to Fixed

According to Jo it's fixed.

Also available in: Atom PDF

Go to top