Project

General

Profile

Bug #11290

An issue with colorpicker if module has two of them

Added by Roman Lebedev over 1 year ago. Updated over 1 year ago.

Status:
New
Priority:
Medium
Assignee:
-
Category:
Darkroom
Target version:
-
Start date:
11/07/2016
Due date:
% Done:

0%

Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Some modules, e.g. color zones, monochrome have a color picker.
And parametric blend has it too.

Now, if you enable colorpicker in monochrome, it will change settings.
Disable it, and enable color picker in parametric blend mode.
It will pick color, but at the same time it will change the monochrome iop params.

With color zones, it will 'just' display the blend colorpick in colorzones main draw.

History

#1 Updated by Ulrich Pegelow over 1 year ago

I think colorpicking has only been recently added to the monochrome module. Seems like it was forgotten that colorpick since some time has three different states (imageop.h):

  DT_REQUEST_COLORPICK_OFF = 0,         // off
  DT_REQUEST_COLORPICK_MODULE = 1 << 0, // requested by module (should take precedence)
  DT_REQUEST_COLORPICK_BLEND = 1 << 1   // requested by parametric blending gui

The monochrome module should only react if the picker is in state DT_REQUEST_COLORPICK_MODULE.

#2 Updated by Ulrich Pegelow over 1 year ago

Should be fixed, isn't it?

#3 Updated by Roman Lebedev over 1 year ago

Not for all the modules.
I think it is still an issue at least for colorzones

Also available in: Atom PDF