Project

General

Profile

Feature #11289

Undo does not know anything about drawn masks

Added by Matthieu Moy over 1 year ago. Updated over 1 year ago.

Status:
New
Priority:
Medium
Assignee:
-
Category:
-
Target version:
-
Start date:
11/06/2016
Due date:
% Done:

0%

Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi, and thanks for this new "undo" feature :-).

It does not work as expected in the "spot removal" module, though.

Steps to reproduce:

  • Open the "spot removal" module
  • Add a stroke (circle, ellipse, ...)
  • Do something else like adding/modifying the parametric mask
  • Add another stroke
  • Press Control-z

Expected result:

The second stroke is removed

Actual result:

The second stroke is not undone, but the "something else" between strokes is undone. This results in a state that never existed before (while I'd expect an "undo" feature to bring me back to a previous state).

History

#1 Updated by Roman Lebedev over 1 year ago

I suspect that is the same problem with every mask.

#2 Updated by Roman Lebedev over 1 year ago

  • Status changed from New to Triaged
  • % Done changed from 0 to 20
  • Assignee set to Roman Lebedev

But for spot removal, i'll try to take a look.

#3 Updated by Roman Lebedev over 1 year ago

  • Priority changed from Low to Medium
  • Assignee deleted (Roman Lebedev)
  • Subject changed from "Undo" does not undo "spot removal" strokes to Undo does not know anything about masks
  • Tracker changed from Bug to Feature
  • Status changed from Triaged to New
  • System changed from Debian to all
  • Affected Version changed from 2.2.0rc0 to git master branch
  • % Done changed from 20 to 0

And, the problem is deeper, because undo only undoes the history stack changes, but it knows nothing about masks, which are completely separate.

#4 Updated by Pascal Obry over 1 year ago

  • Subject changed from Undo does not know anything about masks to Undo does not know anything about drawn masks

Undo/Redo does support parametric masks. Only drawn mask are not supported.

#5 Updated by Roman Lebedev over 1 year ago

Pascal Obry wrote:

Only drawn mask are not supported.

Yes, that is what i meant.

Also available in: Atom PDF