Project

General

Profile

Bug #11273

Can't apply filters to black areas made by transform module

Added by Ben Aceler over 3 years ago. Updated over 3 years ago.

Status:
Closed: invalid
Priority:
Low
Assignee:
-
Category:
-
Target version:
Start date:
10/30/2016
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.0.3
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Transform module can create black areas, when using rotate or perspective correction. It is OK, if there is no information, module can't create one.

But if I want to extend an image a little bit, using, for example, "spot removal" tool, it doesn't work for that black areas.

Screenshot_20161030_002107.png (1.64 MB) Screenshot_20161030_002107.png Ben Aceler, 10/30/2016 12:22 AM

History

#1 Updated by Roman Lebedev over 3 years ago

  • Status changed from New to Closed: invalid

Transform module can create black areas, when using rotate or perspective correction. It is OK, if there is no information, module can't create one.
But if I want to extend an image a little bit, using, for example, "spot removal" tool, it doesn't work for that black areas.

spot removal is applied before crop&rotate, perspective correction.

https://www.darktable.org/usermanual/ch03s02.html.php#pixelpipe

#2 Updated by Ben Aceler over 3 years ago

Roman Lebedev wrote:

Transform module can create black areas, when using rotate or perspective correction. It is OK, if there is no information, module can't create one.
But if I want to extend an image a little bit, using, for example, "spot removal" tool, it doesn't work for that black areas.

spot removal is applied before crop&rotate, perspective correction.

https://www.darktable.org/usermanual/ch03s02.html.php#pixelpipe

There is no black areas before crop&rotate.

#3 Updated by Roman Lebedev over 3 years ago

Ben Aceler wrote:

Roman Lebedev wrote:

Transform module can create black areas, when using rotate or perspective correction. It is OK, if there is no information, module can't create one.
But if I want to extend an image a little bit, using, for example, "spot removal" tool, it doesn't work for that black areas.

spot removal is applied before crop&rotate, perspective correction.

https://www.darktable.org/usermanual/ch03s02.html.php#pixelpipe

There is no black areas before crop&rotate.

Exactly. There is no black areas before crop&rotate.
Since spot removal is applied before crop&rotate, it can not "extend an image a little bit" because there is no black areas to extend the image to.
That is a job for gimp.

#4 Updated by Ben Aceler over 3 years ago

So it's not "invalid", it's "wontfix", right?

Where can I find a good reason why spot removal is applied before crop&rotate?

#5 Updated by Roman Lebedev over 3 years ago

  1. spot removal works on demosaiced data
  2. and needs to be before geometric distortions:
    https://github.com/darktable-org/darktable/blob/master/tools/iop_dependencies.py#L229-L236

And do note that we can't just move modules around.

#6 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top