Project

General

Profile

Camera Support #11181

Lens corrections of Olympus TG-4

Added by Michel Corps over 2 years ago. Updated over 2 years ago.

Status:
Closed: upstream
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
09/27/2016
Due date:
% Done:

0%

Affected Version:
2.0.6

Description

Please support the fixed lens of Olympus TG-4 : TG-4 camera don't appear in the list of Olympus cameras in the lens correction module.

History

#1 Updated by Roman Lebedev over 2 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Incomplete

Lens support is lenfun problem.
In lens correction module, how does the darktable display lens name ?

#2 Updated by Michel Corps over 2 years ago

Roman Lebedev wrote:

Lens support is lenfun problem.
In lens correction module, how does the darktable display lens name ?

It doesn't display camera model (TG-4) so it cannot display lens name.

#3 Updated by Roman Lebedev over 2 years ago

  • Status changed from Incomplete to Closed: upstream
  • % Done changed from 20 to 0

If you can not manually select that camera and/or lens from these 2 lists it means those are not supported by lensfun yet.
You need to report that against lensfun.

#4 Updated by Michel Corps over 2 years ago

Roman Lebedev wrote:

If you can not manually select that camera and/or lens from these 2 lists it means those are not supported by lensfun yet.
You need to report that against lensfun.

Ok, thanks for this quick answer. I just found that : https://redmine.darktable.org/attachments/1746/lensfun-oly-tg4.xml

Can I add this file manually in the right directory to get "non official" TG-4 support ?

#6 Updated by Michel Corps over 2 years ago

Roman Lebedev wrote:

Yes, http://lensfun.sourceforge.net/manual/dbsearch.html

I found a post from Torsten Bronger of december 2015 where he said that he just added this file into the db. But in fact it doesn't appear even in the recent last version. I wrote him an email to ask about this point.

Anyway thanks you so much for the answers !

#7 Updated by Torsten Bronger over 2 years ago

The data is in Lensfun's database, and it works for me out-of-the-box. Please assure that Lensfun is successfully reading the file that contains “Olympus Stylus TG-4” in it. As a start, you should call darktable from the command line and watch for error messages of Lensfun. Moreover, you can add

<!DOCTYPE lensdatabase SYSTEM "lensfun-database.dtd">
<lensdatabase version="1">

    <camera>
        <maker>Olympus Corporation</maker>
        <maker lang="en">Olympus</maker>
        <model>TG-4</model>
        <model lang="en">Stylus TG-4</model>
        <mount>olympusStylusTG4</mount>
        <cropfactor>5.56</cropfactor>
    </camera>

    <lens>
        <maker>Olympus</maker>
        <model>Olympus Stylus TG-4 &amp; compatibles</model>
        <model lang="en">fixed lens</model>
        <model lang="de">festes Objektiv</model>
        <mount>olympusStylusTG4</mount>
        <cropfactor>5.56</cropfactor>
        <aspect-ratio>4:3</aspect-ratio>
        <calibration>
            <!-- Taken with Olympus Stylus TG-4 -->
            <distortion model="poly3" focal="4.5" k1="-0.04661"/>
            <distortion model="poly3" focal="5.1" k1="-0.03028"/>
            <distortion model="poly3" focal="6.9" k1="-0.00581"/>
            <distortion model="poly3" focal="9" k1="0.00574"/>
            <distortion model="poly3" focal="18" k1="0.01525"/>
            <tca model="poly3" focal="4.5" br="-0.0000440" vr="1.0004022" bb="0.0000003" vb="1.0000025"/>
            <tca model="poly3" focal="5.1" br="0.0000436" vr="1.0002117" bb="-0.0000141" vb="1.0000376"/>
            <tca model="poly3" focal="6.9" br="-0.0000276" vr="1.0001322" bb="-0.0000199" vb="1.0000921"/>
            <tca model="poly3" focal="9" br="-0.0000200" vr="1.0000631" bb="-0.0000128" vb="1.0000870"/>
            <tca model="poly3" focal="18" br="-0.0000067" vr="0.9999876" bb="-0.0000838" vb="1.0000917"/>
        </calibration>
    </lens>

</lensdatabase>

as a new file in `~/.local/share/lensfun/` (and again, watch for error messages).

#8 Updated by Michel Corps over 2 years ago

Torsten Bronger wrote:

The data is in Lensfun's database, and it works for me out-of-the-box. Please assure that Lensfun is successfully reading the file that contains “Olympus Stylus TG-4” in it. As a start, you should call darktable from the command line and watch for error messages of Lensfun. Moreover, you can add

[...]

as a new file in `~/.local/share/lensfun/` (and again, watch for error messages).

I am confused... I downloaded the last lensfun from sourceforge (v0.3.2) and I failed to find any TG-4 camera into Olympus related xml files. So, what I am doing wrong ???

#9 Updated by Torsten Bronger over 2 years ago

Please call “lensfun-update-data” on the command line.

#10 Updated by Michel Corps over 2 years ago

Torsten Bronger wrote:

Please call “lensfun-update-data” on the command line.

Before to do that, I would like to understand something : I checked all olympus xml files of lensfun v0.3.2 archive downloaded on SourceForge and none include a TG-4 camera. How it could work out of the box ? Is there others files I have to check in this archive ?

#11 Updated by Torsten Bronger over 2 years ago

The TG-4 was added in 2015-12 but Lensfun 0.3.2 is of 2015-11. Thus, you need to update your database with the mentioned command.

#12 Updated by Michel Corps over 2 years ago

Torsten Bronger wrote:

The TG-4 was added in 2015-12 but Lensfun 0.3.2 is of 2015-11. Thus, you need to update your database with the mentioned command.

Oh, now I understand better :-) My mistake, sorry.

Thanks you for the help !

#13 Updated by Roman Lebedev over 2 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF