Project

General

Profile

Feature #11173

White background under image and a light theme

Added by Serhiy Kobyakov over 2 years ago. Updated about 2 years ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
09/24/2016
Due date:
% Done:

0%

Affected Version:
2.0.6
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi!

I make microstock images. All of them are shown on white background in every microstock agency's site.

The problem is - when I do color adjustment on image which is on dark background (interface), it looks dull on white. It is happened because of eyes adaptation. Not sure about exact theory, but
the same image looks brighter and more saturated on black (dark) background than it is on white.

Therefore, it would be great to have an option to set white background around image and a lighter interface. Just like it is in RawTherapee (92-Beige-DarkCyan theme - do not feel it is good because of color cast, but it is bright) and Gimp (00-lighter theme).

I tried to edit darktablerc, made theme lighter, but see no possibility to make white background under image - it is still dark gray...

History

#1 Updated by a s over 2 years ago

For me, this feature is also quite important. Almost all images are published on white (or at least light) background and developing images on dark background, and developing them in dark context is a pitfall because after publication they see quite different. They are just pale, and lacks of contrast.

I just changed styles in /usr/share/darktable/darktable.css but I can't change background under photo in darkroom, at least some could tell how to do this (my version looks like this https://github.com/ip413/darktable-light-theme/blob/master/dartable-light.gif ).

#2 Updated by Aurélien PIERRE over 2 years ago

The background color is hardcoded in /src/views/darkroom.c:198 and /src/views/darkroom.c:200. I had to change cairo_set_source_rgb(cr, .1, .1, .1); (dark gray) to cairo_set_source_rgb(cr, .5, .5, .5); (50% gray).

Altough the theming and templating concern is relevant, the real problem here is that some parts of the style are in a stylesheet (GTK style, user editable) and some other in the C sourcecode (compiled, not editable). So basically, what is needed is a clean up to seperate content and display in the source code.

#3 Updated by Roman Lebedev over 2 years ago

Aurélien PIERRE wrote:

The background color is hardcoded in /src/views/darkroom.c:198 and /src/views/darkroom.c:200. I had to change cairo_set_source_rgb(cr, .1, .1, .1); (dark gray) to cairo_set_source_rgb(cr, .5, .5, .5); (50% gray).

Altough the theming and templating concern is relevant, the real problem here is that some parts of the style are in a stylesheet (GTK style, user editable) and some other in the C sourcecode (compiled, not editable). So basically, what is needed is a clean up to seperate content and display in the source code.

Yes, and one day that shall happen.
Patches welcomed :)

As for light theme..

#4 Updated by Serhiy Kobyakov over 2 years ago

Thank you Roman, for now it works like this and I am happy )

Hope in future we would have it as option in preferences...

#5 Updated by Aurélien PIERRE over 2 years ago

Roman Lebedev wrote:

Aurélien PIERRE wrote:

The background color is hardcoded in /src/views/darkroom.c:198 and /src/views/darkroom.c:200. I had to change cairo_set_source_rgb(cr, .1, .1, .1); (dark gray) to cairo_set_source_rgb(cr, .5, .5, .5); (50% gray).

Altough the theming and templating concern is relevant, the real problem here is that some parts of the style are in a stylesheet (GTK style, user editable) and some other in the C sourcecode (compiled, not editable). So basically, what is needed is a clean up to seperate content and display in the source code.

Yes, and one day that shall happen.
Patches welcomed :)

As for light theme..

Yeah I'm currently working to improve my C skills in order to start working on DT. Do you have any doc/manual to get started ? The DT dev wiki is pretty arid. I'm fluent in Python/Matlab/PHP but I used C only in Arduino's IDE and I'm a total noob in GUI.

#6 Updated by Tobias Ellinghaus over 2 years ago

We would want a list of predefined colors in dt_gui_gtk_t (src/gui/gtk.h) that is initialized with sane defaults in dt_gui_gtk_init() (src/gui/gtk.c) and ontop of that the CSS has to be queried once loaded to set the user defined colors. Then go through all the files that are setting hardcoded colors and decide for every color what pre defined one to map it to, then use that. It's nothing complicated, it's just tedious. And the first version will most likely need to get changed because we won't like your choice of the color set. :-)

#7 Updated by Andrew Steinke about 2 years ago

The ability to modify the background colors as CSS is added in the merged PR #1420 https://github.com/darktable-org/darktable/pull/1420

Here is a git diff to change the background for editing & lighttable view to white
https://gist.githubusercontent.com/rkcf/41683f4106f0ae5ea62e6590fd1b4a92/raw/8889f25449ad03d4a068f0616d87b952771ffc64/gistfile1.txt

Also available in: Atom PDF