Project

General

Profile

Bug #11166

Un-demosaicing preview pipe broke preview for CYGM cameras

Added by Roman Lebedev over 3 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
09/20/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

$ git bisect log
git bisect start
  1. bad: [d1652615c5e5f3372dfc43325ce7b5991be2a494] dt_iop_clip_and_zoom_mosaic_half_size*(): don't forget about offset.
    git bisect bad d1652615c5e5f3372dfc43325ce7b5991be2a494
  2. good: [5e9f5e344221148a218088ea0ef8cb8fbbd0e2c2] Hard-require C++11. + some cmake changes
    git bisect good 5e9f5e344221148a218088ea0ef8cb8fbbd0e2c2
  3. good: [13a207b4105e0368f02cf40f8929e1cd375a34aa] dt_dev_pixelpipe_uses_downsampled_input() is no more.
    git bisect good 13a207b4105e0368f02cf40f8929e1cd375a34aa
  4. bad: [91d54ac8cfe15e052a745e05012c79ddcb9fab9f] _init_f(): correct scaling factor calculation
    git bisect bad 91d54ac8cfe15e052a745e05012c79ddcb9fab9f
  5. good: [7b2cea19227a9f52c39af6cc35b85ffb6caf2a6e] Bayer uint16_t: implement proper downscaling, with sub-pixel sampling.
    git bisect good 7b2cea19227a9f52c39af6cc35b85ffb6caf2a6e
  6. good: [6c2ad3f75cfaf4f78aaeff56a32257724ecf9810] Bayer float: implement proper downscaling, with sub-pixel sampling.
    git bisect good 6c2ad3f75cfaf4f78aaeff56a32257724ecf9810
  7. first bad commit: [91d54ac8cfe15e052a745e05012c79ddcb9fab9f] _init_f(): correct scaling factor calculation
  8. good: [6c2ad3f75cfaf4f78aaeff56a32257724ecf9810] Bayer float: implement proper downscaling, with sub-pixel sampling.
    git bisect good 6c2ad3f75cfaf4f78aaeff56a32257724ecf9810
  9. first bad commit: [91d54ac8cfe15e052a745e05012c79ddcb9fab9f] _init_f(): correct scaling factor calculation
  10. bad: [91d54ac8cfe15e052a745e05012c79ddcb9fab9f] _init_f(): correct scaling factor calculation
    git bisect bad 91d54ac8cfe15e052a745e05012c79ddcb9fab9f
  11. first bad commit: [91d54ac8cfe15e052a745e05012c79ddcb9fab9f] _init_f(): correct scaling factor calculation

^ strange

Associated revisions

Revision 069118ea (diff)
Added by Roman Lebedev over 3 years ago

Populate ugly FILTERS_ARE_4BAYER() with more values. Fixes #11166.

The problem is that it may compare those values with arbitrary
shifted pattern. So for every 4-color CFA this needs to contain
all 4 different variants.

This is absolutely horrible.

Revision e748add1 (diff)
Added by Roman Lebedev over 3 years ago

Populate ugly FILTERS_ARE_4BAYER() with more values. Fixes #11166.

The problem is that it may compare those values with arbitrary
shifted pattern. So for every 4-color CFA this needs to contain
all 4 different variants.

This is absolutely horrible.

(cherry picked from commit 069118ea0294dc7b0ebd9ef4ef8b887464310ba8)

History

#1 Updated by Roman Lebedev over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

#2 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top