Project

General

Profile

Bug #11164

Un-demosaicing preview pipe broke spot invert

Added by Roman Lebedev over 2 years ago. Updated over 2 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
09/20/2016
Due date:
% Done:

100%

Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Associated revisions

Revision e988f756
Added by Roman Lebedev over 2 years ago

Merge remote-tracking branch 'upstream/pr/1279'

Color picker fixes.

Spot whitebalance and spot invert was broken by un-demosaicing of
preview pipe.
This fixes it.

According to @upegelow, OpenCL part of the changes is unsufficient.

Since i have no opencl to fix it, and this already is much better than
what git master currently have, i'm merging it as it is.

Fixes #11163.
Fixes #11164.

  • upstream/pr/1279:
    Invert iop: fix deadlock
    Invert iop: 4Bayer changes
    Temperature iop: spot wb: support 4Bayer
    Color picker: support 4Bayer.
    pixelpipe_picker_cl(): roi_copy: passthrough proper x,y
    Color picker: support picking from X-Trans mosaic
    Color picker: support picking from Bayer mosaic
    Color picker: refactor computations into worker, properly check input type
    pixelpipe_picker_cl(): use dt_iop_buffer_dsc_to_bpp()
    Color picker: take dt_iop_buffer_dsc_t*
    Pixelpipe: pixelpipe_picker{,_cl}: refactor common setup code into helper
    Refactor actual color picking into new .[CH]

History

#1 Updated by Roman Lebedev over 2 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

#2 Updated by Roman Lebedev over 2 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF