Project

General

Profile

Bug #11136

shadows & highlights turns highlights purple

Added by Moritz Moeller over 3 years ago. Updated over 3 years ago.

Status:
Closed: invalid
Priority:
Low
Assignee:
-
Category:
-
Target version:
Start date:
09/06/2016
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.0.6
System:
Mac OS X
bitness:
64-bit
hardware architecture:
amd64/x86

Description

See attached example. The lamp's bulb turns purple. This is cased by the shadows & highlights module.

XMP/JPEG was created with a custom build of 2.1.0+1447~ge317ef7.

Archive.zip (27.3 MB) Archive.zip Moritz Moeller, 09/06/2016 03:31 PM
_dsc1087.dng.xmp (8.1 KB) _dsc1087.dng.xmp Moritz Moeller, 09/06/2016 04:53 PM

History

#1 Updated by Roman Lebedev over 3 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Incomplete

Set gamut clip to linear rec2020 rgb in input color profile.
Seems to fix the issue for me on that sample.

And, please attach files separately :)

#2 Updated by Moritz Moeller over 3 years ago

If I set (any) gamut clipping, won't I loose information in my highlights. I.e., if I dial them down later, they'll be flat?

#3 Updated by Roman Lebedev over 3 years ago

Moritz Moeller wrote:

rec2020 changes color rendering profoundly vs the embedded Sony matrix. I.e. that's not a fix and not really a workaround, unless I wanted to convert this image to B&W.

Go read my comment again

#4 Updated by Roman Lebedev over 3 years ago

Moritz Moeller wrote:

If I set (any) gamut clipping, won't I loose information in my highlights. I.e., if I dial them down later, they'll be flat?

The real highlights have been handled in highlights iop.
After demosaic, there are no actual highlights.

Rec2020 is sufficiently larger than any camera gamut.

See also https://www.darktable.org/usermanual/ch03s04s03.html.php#d0e8231

#5 Updated by Moritz Moeller over 3 years ago

Ok, thanks for clearing that up.

One more question:
"After demosaic, there are no actual highlights."

That seems like big shortcoming of the DT pipe? I mean demosaic is quite early, no? After that everything is in 0..1? Am I missing something here?

#6 Updated by Roman Lebedev over 3 years ago

Moritz Moeller wrote:

Ok, thanks for clearing that up.

One more question:
"After demosaic, there are no actual highlights."

That seems like big shortcoming of the DT pipe? I mean demosaic is quite early, no?

After that everything is in 0..1?

Uh, not what i meant :)
We do not clip to 0..1, anywhere.
Not sure what i wanted to say with that phrase.

Am I missing something here?

Anyway, we have not seen any negative impact from gamut clipping so far.

#7 Updated by Moritz Moeller over 3 years ago

Actually, when I switch the Gamut clipping to rec2020, my whole image turns a stop brighter. XMP attached. This seems to be some modules interacting with each other, it didn't happen in the simple module setup I attached to this ticket initially.

#8 Updated by Roman Lebedev over 3 years ago

Moritz Moeller wrote:

Actually, when I switch the Gamut clipping to rec2020, my whole image turns a stop brighter. XMP attached. This seems to be some modules interacting with each other, it didn't happen in the simple module setup I attached to this ticket initially.

Does not happen with global tonemap = off
But this is for new issue.

#9 Updated by Moritz Moeller over 3 years ago

But this is for new issue.

i'll create one.

#10 Updated by Roman Lebedev over 3 years ago

  • % Done changed from 20 to 0
  • Status changed from Incomplete to Closed: invalid

#11 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top