Project

General

Profile

Bug #11108

Cameras.xml name "de-"mangling is broken, especially for nikon

Added by Andreas Schneider over 3 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Medium
Assignee:
-
Category:
General
Target version:
Start date:
08/10/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

If you try to create a HDR image with NEF files from a Nikon D7200 it fails. It is not able to load the white balance. The error is:

[colorin] `NIKON CORPORATION NIKON D7200' color matrix not found!

If you edit the file 'rawspeed/cameras.xml' and then search for D7200 you will find two entries:

make="NIKON CORPORATION" model="NIKON D7200" mode="14bit-compressed"
make="NIKON CORPORATION" model="NIKON D7200" mode="12bit-compressed"

but no entry for

make="NIKON CORPORATION" model="NIKON D7200"

Duplicating the one of the existing entries and changing it to: make="NIKON CORPORATION" model="NIKON D7200" fixes the issue.


Related issues

Related to darktable - Bug #11316: darktable hdr brokenClosed: invalid11/14/2016

Has duplicate darktable - Feature #11183: DNG: ISO field readingDuplicate09/27/2016

Has duplicate darktable - Bug #11192: DNG from NEF HDR stack DT returns "...file color matrix not found"Duplicate10/02/2016

Precedes darktable - Bug #11355: rawspeed getCamera() with prefix-search issueFixed12/12/201612/12/2016

Associated revisions

Revision c4b3a45a (diff)
Added by Roman Lebedev over 3 years ago

Rawspeed: CameraMetadata: implement getCamera() with prefix-search.

Needed to look for camera with only maker + model known, but no mode.
Here i'm assuming that for all the camera modes we have
the same <ID> name mangling.

This is only needed to de-mangle camera name. SIGH

Refs #11108

Revision ab361179 (diff)
Added by Roman Lebedev over 3 years ago

Rawspeed: DngDecoder: decodeMetaDataInternal(): use new getCamera(). Fixes #11108

The new variant of getCamera() looks for any camera entry with
given maker and model, and any mode.

Here i'm assuming that for all the camera modes we have the same
<ID> name mangling. This is only needed to de-mangle camera name.

SIGH

History

#1 Updated by Roman Lebedev over 3 years ago

  • System changed from openSUSE to all
  • Affected Version changed from 2.0.5 to git master branch
  • % Done changed from 0 to 10
  • Status changed from New to Confirmed
  • Subject changed from White balance for Nikon D7200 HDR (dng file) generation does not work to Cameras.xml name "de-"mangling is broken - Nikon D7200 HDR (dng file)

#2 Updated by Roman Lebedev over 3 years ago

#3 Updated by Roman Lebedev over 3 years ago

  • Has duplicate Bug #11192: DNG from NEF HDR stack DT returns "...file color matrix not found" added

#4 Updated by Tobias Wegener over 3 years ago

I do encounter exactly the same problem with my Nikon D7000 and Nikon D750.
On Ubuntu 14.04 and Ubuntu 16.04 on the newest stable Darktable version 2.0.7

"Andreas Schneider wrote:

If you try to create a HDR image with NEF files from a Nikon D7200 it fails. It is not able to load the white balance. The error is:

[colorin] `NIKON CORPORATION NIKON D7200' color matrix not found!

If you edit the file 'rawspeed/cameras.xml' and then search for D7200 you will find two entries:

make="NIKON CORPORATION" model="NIKON D7200" mode="14bit-compressed"
make="NIKON CORPORATION" model="NIKON D7200" mode="12bit-compressed"

but no entry for

make="NIKON CORPORATION" model="NIKON D7200"

Duplicating the one of the existing entries and changing it to: make="NIKON CORPORATION" model="NIKON D7200" fixes the issue."

#5 Updated by Roman Lebedev over 3 years ago

Tobias Wegener wrote:

I do encounter exactly the same problem with my Nikon D7000 and Nikon D750.

Yep, this affects every nikon camera.

"Andreas Schneider wrote:

If you try to create a HDR image with NEF files from a Nikon D7200 it fails. It is not able to load the white balance. The error is:

[colorin] `NIKON CORPORATION NIKON D7200' color matrix not found!

If you edit the file 'rawspeed/cameras.xml' and then search for D7200 you will find two entries:

make="NIKON CORPORATION" model="NIKON D7200" mode="14bit-compressed"
make="NIKON CORPORATION" model="NIKON D7200" mode="12bit-compressed"

but no entry for

make="NIKON CORPORATION" model="NIKON D7200"

Duplicating the one of the existing entries and changing it to: make="NIKON CORPORATION" model="NIKON D7200" fixes the issue."

#6 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

#7 Updated by Roman Lebedev over 3 years ago

  • Priority changed from Low to Medium
  • Category changed from Darkroom to General
  • Subject changed from Cameras.xml name "de-"mangling is broken - Nikon D7200 HDR (dng file) to Cameras.xml name "de-"mangling is broken, especially for nikon

#8 Updated by Roman Lebedev over 3 years ago

  • Related to Bug #11316: darktable hdr broken added

#9 Updated by Roman Lebedev over 3 years ago

  • % Done changed from 10 to 100
  • Status changed from Confirmed to Fixed

#10 Updated by Roman Lebedev about 3 years ago

  • Precedes Bug #11355: rawspeed getCamera() with prefix-search issue added

Also available in: Atom PDF

Go to top