Project

General

Profile

Bug #11102

Map- and Geotagging-Modules should be independent

Added by Markus Kaindl over 3 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Buildsystem
Target version:
Start date:
07/30/2016
Due date:
% Done:

100%

Estimated time:
1.00 h
Affected Version:
2.0.5
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

I don't see any reason, why you can only build these two together.
Currently they both are (de-)activated with USE_GEO.
I would suggest two new USE-Options, i.e. MAP and GEOTAGGING, which disable the two modules independently.
For consistency I would also suggest, to keep the current behavior of USE_GEO, so if it is set to ON (current default) and MAP/GEOTAGGING are both unset, both are built, but you are able to disable each off them.

One reason, why I found this: The Map-Module needs >=osm-gps-map-1.0, in my current OS (Gentoo Linux) only a older Version is packaged, so the official Gentoo-Package has GEO disabled. I do use the Geotagging-Module almost everytime when I import new Photos but I never use the Map-Module. If thats only me, I will keep my local patch, but I think, there could be many more out there, using it like me.

PS: Please change affected Version to whatever rules apply here, because AFAIK its Affected from somewhere around 1.1 until current master. I set it to the Version, I currently use: 2.0.5

Associated revisions

Revision 14f20a6a (diff)
Added by Markus Kaindl over 3 years ago

Rename USE_GEO -> USE_MAP, build geotagging unconditionally

Fixes #11102

Revision 4da04ad9
Added by Roman Lebedev over 3 years ago

Merge pull request #1244 from kaindl/#11102

Rename USE_GEO -> USE_MAP, build geotagging unconditionally. Fixes #11102

History

#1 Updated by Markus Kaindl over 3 years ago

I created a Pull Request:
https://github.com/darktable-org/darktable/pull/1244

After talking to LebedevRI in IRC, the idea with seperate options was dropped.
Geotagging is now always built, the option is renamed to "USE_MAP" and only affects the map

#2 Updated by Anonymous over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

#3 Updated by Roman Lebedev over 3 years ago

  • Target version changed from Candidate for next patch release to 2.2.0

Also available in: Atom PDF

Go to top