Map- and Geotagging-Modules should be independent
I don't see any reason, why you can only build these two together.
Currently they both are (de-)activated with USE_GEO.
I would suggest two new USE-Options, i.e. MAP and GEOTAGGING, which disable the two modules independently.
For consistency I would also suggest, to keep the current behavior of USE_GEO, so if it is set to ON (current default) and MAP/GEOTAGGING are both unset, both are built, but you are able to disable each off them.
One reason, why I found this: The Map-Module needs >=osm-gps-map-1.0, in my current OS (Gentoo Linux) only a older Version is packaged, so the official Gentoo-Package has GEO disabled. I do use the Geotagging-Module almost everytime when I import new Photos but I never use the Map-Module. If thats only me, I will keep my local patch, but I think, there could be many more out there, using it like me.
PS: Please change affected Version to whatever rules apply here, because AFAIK its Affected from somewhere around 1.1 until current master. I set it to the Version, I currently use: 2.0.5
#1 Updated by Markus Kaindl almost 4 years ago
I created a Pull Request:
After talking to LebedevRI in IRC, the idea with seperate options was dropped.
Geotagging is now always built, the option is renamed to "USE_MAP" and only affects the map
#2 Updated by Anonymous almost 4 years ago
- % Done changed from 0 to 100
- Status changed from New to Fixed
Applied in changeset darktable|14f20a6ad8877c62684f77bb65163b507eeaed4d.