Project

General

Profile

Bug #11088

dprintf issue during compilation on Openindiana (Solaris)

Added by Ben Franck over 3 years ago. Updated over 3 years ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
07/22/2016
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.0.5
System:
Solaris
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi,
I use :
latest Openindiana Hipster (SunOS oi-build 5.11 illumos-8ee802c i86pc i386 i86pc Solaris)
gcc version 4.9.3

When I compile, it fails at :

cd /home/ben/tmp/darktable/dk_build/src && /usr/bin/gcc -DGDK_DISABLE_DEPRECATED -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_MIN_REQUIRED -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_32 -DGTK_DISABLE_DEPRECATED -DGTK_DISABLE_SINGLE_INCLUDES -DHAVE_BUILTIN_CPU_SUPPORTS -DHAVE_CONFIG_H -DHAVE_GKEYRING -DHAVE_HTTP_SERVER -DHAVE_KWALLET -DHAVE_LENSFUN -DHAVE_OPENCL -DHAVE_OPENEXR -DHAVE_OPENJPEG -DHAVE_OPENJPEG_ICC -DHAVE_PRINT -DUSE_GETTEXT -DUSE_LUA -D_XOPEN_SOURCE=600 -D__GDK_KEYSYMS_COMPAT_H__ -Dlib_darktable_EXPORTS -D__SUNOS__ -std=c99 -fopenmp -Wall -fno-strict-aliasing -pthread -msse4.2 -msse3 -g -mfpmath=sse -D_RELEASE -O3 -DNDEBUG -O3 -ffast-math -fno-finite-math-only -fexpensive-optimizations -fPIC -I/home/ben/tmp/darktable/darktable-release-2.0.5/src -I/home/ben/tmp/darktable/darktable-release-2.0.5/src/external -I/usr/include/gtk-3.0 -isystem /usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/atk-1.0 -isystem /usr/include/libxml2 -isystem /usr/include/libsoup-2.4 -isystem /usr/include/glib-2.0 -isystem /usr/lib/glib-2.0/include -isystem /usr/include/OpenEXR -isystem /usr/local/include/lensfun -isystem /usr/include/librsvg-2.0 -isystem /usr/include/lcms2 -isystem /usr/include/json-glib-1.0 -isystem /usr/local/include/exiv2 -isystem /usr/include/openjpeg-2.1 -isystem /usr/include/gnome-keyring-1 -I/home/ben/tmp/darktable/dk_build/src -isystem /usr/local/include -I/home/ben/tmp/darktable/darktable-release-2.0.5/src/external/LuaAutoC -isystem /usr/include/cups -Werror=implicit-function-declaration -o CMakeFiles/lib_darktable.dir/common/darktable.c.o -c /home/ben/tmp/darktable/darktable-release-2.0.5/src/common/darktable.c
/home/ben/tmp/darktable/darktable-release-2.0.5/src/common/darktable.c:151:1: error: expected ',' or ';' before '{' token {
^
/home/ben/tmp/darktable/darktable-release-2.0.5/src/common/darktable.c:150:12: warning: 'dprintf' used but never defined
static int dprintf(int fd, const char fmt, ...) attribute((format(printf, 2, 3)))
^
src/CMakeFiles/lib_darktable.dir/build.make:282: recipe for target 'src/CMakeFiles/lib_darktable.dir/common/darktable.c.o' failed
gmake2: *
* [src/CMakeFiles/lib_darktable.dir/common/darktable.c.o] Error 1

History

#1 Updated by Roman Lebedev over 3 years ago

So i'm going to guess that dprintf() is avaliable on some systems, and on others we "stub"-define it
https://github.com/darktable-org/darktable/blob/master/src/common/darktable.c#L150-L151

My guess would be -D__SUNOS__

Now, is there any other define (like (OpenBSD < 201305))) that we can use to conditionally disable compilation of our "stub" dprintf() on this system?

Also available in: Atom PDF

Go to top