Project

General

Profile

Camera Support #11028

Canon 80D - m/s-RAW support

Added by Ryan Gillette over 3 years ago. Updated about 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
-
Target version:
Start date:
05/13/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version

Description

Here are some sample images from the Canon 80D. 2 RAW straight from the camera and 2 DNG files using Adobe DNG converter 9.5.1. Tried to upload more photos but kept getting an error. Below is a link to public dropbox with more samples. I am running darktable-git release.2.1.0.r1031.gdf4eb00-1 from Arch AUR.

ISO range:
100,125,160,200,250,320,400,500,640,800,1000,1250,1600,2000,2500,3200,4000,5000,6400,8000,10000,12800,16000
"H" (expanded equivalent) 25600

https://www.dropbox.com/sh/17yxb36piaok77c/AADicWPIyZbSjIMT105mYfHma?dl=0

80D.txt (9.54 KB) 80D.txt White balance presets with amber-blue fine tune Robert Hutton, 06/17/2016 10:34 AM

Associated revisions

Revision 84981748 (diff)
Added by Stefan Löffler over 3 years ago

RawSpeed: Canon EOS 80D: add support for mRaw and sRaw formats (fixes #11028)

New decoder hint: wrapped_cr2_slices

Revision 5afba886
Added by Roman Lebedev over 3 years ago

Merge remote-tracking branch 'upstream/pr/1294'

  • upstream/pr/1294:
    RawSpeed: Canon EOS 80D: add support for mRaw and sRaw formats (fixes #11028)

Revision d3a29733 (diff)
Added by Stefan Löffler over 3 years ago

RawSpeed: Canon EOS 80D: add support for mRaw and sRaw formats (fixes #11028)

New decoder hint: wrapped_cr2_slices

(cherry picked from commit 8498174895256a5b73bebf56314074cbb2124225)

History

#1 Updated by Ryan Gillette over 3 years ago

Let me know if there is anything else that I can help with or test.

#2 Updated by Ryan Gillette over 3 years ago

RawSpeed:Unable to find camera in database: Canon Canon EOS 80D
[rawspeed] Camera 'Canon' 'Canon EOS 80D', mode '' not supported, and not allowed to guess. Sorry.
[temperature] failed to read camera white balance information from `IMG_0003.CR2'!
[colorin] `Canon Canon EOS 80D' color matrix not found!
[colorin] `Canon Canon EOS 80D' color matrix not found!
[colorin] `Canon Canon EOS 80D' color matrix not found!

#3 Updated by Ryan Gillette over 3 years ago

libgphoto2 has been updated on git to have basic support for the 80D.

#4 Updated by Ryan Gillette over 3 years ago

Added pull request for some basic support for the 80D, still needs some work, but darktable does not crash now when opening the files.

The images have a pink hue to them, and there is a black bar up the left side.

#5 Updated by Ryan Gillette over 3 years ago

Full Canon 80D support has been added. Black area, and pink hue is gone.

#6 Updated by Bill Roberts over 3 years ago

Hi Ryan,

Thanks for working on the 80D support for Darktable. Is there any way I can get access to your 80D mods? I recently bought an 80D and now have 1100 holiday photos I can't develop :-)

Regards, Bill Roberts

#8 Updated by Bill Roberts over 3 years ago

Thanks!

#9 Updated by Ryan Gillette over 3 years ago

Updated my branch again, changed the values for the black area and crop. Also atempting to work on support for mRAW and sRAW on the 80D. sRAW seems to work fine, but mRAW has some issues. I think that has to be fixed by someone that knows more about how the libs handle RAW files on the backend.

#10 Updated by Edward Kamau over 3 years ago

I have done the WB preset shots for all the presets + the WB shifts. 20
shots per preset (did 2 for the 0 shift). All in folders and uploaded to my
google drive here:

https://drive.google.com/open?id=0B_mzuqJlg3wtUVBJSFowNmduQjA

Let me know if I need to post elsewhere rather than here. I will also post this in the mailing list.
Edward

#11 Updated by Ryan Gillette over 3 years ago

Thanks for doing this. I am not sure what information would need to be updated in the code for this. Any pointers would be great :)

#12 Updated by Roman Lebedev over 3 years ago

Ryan Gillette wrote:

Thanks for doing this. I am not sure what information would need to be updated in the code for this. Any pointers would be great :)

https://github.com/darktable-org/darktable/blob/master/src/external/wb_presets.c
apply https://github.com/darktable-org/darktable/blob/master/tools/extract_wb to those raw files
(or wb_extract.pl from ufraw)

#13 Updated by Edward Kamau over 3 years ago

I also did noise profiling shots, assuming they may still be helpful. If I figure out how to make a noise profile myself I will post it.

They are here: https://drive.google.com/open?id=0B_mzuqJlg3wtaFRUUTkyVGVDUWM
Theres a README.txt there with the gory details.

#14 Updated by Ryan Gillette over 3 years ago

If i get some more time, i will see if i can get ruby setup to use extract_wb, i am getting some errors, and not really familiar with ruby.

#15 Updated by Robert Hutton over 3 years ago

I managed to run ufraw's wb_extract.pl after upgrading my exiftool to version 10.20 to handle the 80D files. I then cleaned up the output, please find it attached.

#16 Updated by Robert Hutton over 3 years ago

OK, I've run gen-profile on Set1 of the noise profile images, with an updated rawspeed database from Ryan's repo. I still get this warning, not sure if it will affect the result:

[colorin] `Canon Canon EOS 80D' color matrix not found!

Output attached, ready for hanatos' review.

#17 Updated by Robert Hutton over 3 years ago

File attach failed, so here's a link: https://dl.dropboxusercontent.com/u/249337/dt-noiseprofile-20160617.tar.gz

Edit: I've deleted that file as it was done with a version of darktable that didn't have proper 80D support. New file is here: https://dl.dropboxusercontent.com/u/249337/dt-noiseprofile-20160618.tar.gz

#18 Updated by Ryan Gillette over 3 years ago

Did you build DT from my repo?
There are 2 files that were edited to add 80D support. That was one of the errors I was getting before I added the support. Also if your building from local repo with ./build.sh file, the installl path for darktable will be /opt/darktable/bin/darktable. If you have a version installed from your distros repo, then you might still be launching that version by mistake.

#19 Updated by Ryan Gillette over 3 years ago

I have added and commit the white balance to my git repo on both master and canon-80d branch

#20 Updated by Robert Hutton over 3 years ago

I've built dt from your repo now, see above comment #17 for the link to the new noise profile.

#21 Updated by Robert Hutton over 3 years ago

Here's the noise profile from the second set of images: https://dl.dropboxusercontent.com/u/249337/dt-noiseprofile-20160618_2.tar.gz

Result looks almost indistinguishable from set 1.

#22 Updated by Bill Roberts over 3 years ago

I've built DT with Ryan's mods and added Robert's noise profile. It's all working really well for my 80D images. Thank you to both of you.

#23 Updated by Ryan Gillette over 3 years ago

Your welcome. :)
I am glad its working well for you. The only thing I can not fix is mRAW files. They come out stair stepped. Full RAW and sRAW work perfectly.

#24 Updated by Ryan Gillette over 3 years ago

Noise profiles for Canon 80D have been added in to Canon 80D branch, hopefully it will get merged in the next few days :)

#25 Updated by Roman Lebedev over 3 years ago

  • % Done changed from 0 to 50
  • Status changed from New to In Progress

As of this moment, the only thing missing is s/m-RAW support.

#26 Updated by Ryan Gillette over 3 years ago

Added sRAW and mRAW samples to the dropbox folder.
https://www.dropbox.com/sh/17yxb36piaok77c/AADicWPIyZbSjIMT105mYfHma?dl=0

#27 Updated by Roman Lebedev over 3 years ago

  • % Done changed from 50 to 100
  • Status changed from In Progress to Fixed

I think this is fully fixed, no?

#28 Updated by Ryan Gillette over 3 years ago

90% complete, I would say. mRAW and sRAW still do not load, but not 100% sure if its something that needs to be fixed in DT.

#29 Updated by Bill Roberts over 3 years ago

One other thing I've noticed is that the 80D is not in the drop-down list of cameras in the "lens correction" module. You see "camera/lens not found - please select manually".

#30 Updated by Ryan Gillette over 3 years ago

Lens correction was working for me. I have reloaded my machine since then and now its not working. I think I had to manually enter the 80D information somewhere for that but I cannot remember now. I will do some digging and see if I can find it.

#31 Updated by Ryan Gillette over 3 years ago

Found it.
Need to edit /usr/share/lensfun/version_1/slr-canon.xml

Find Canon 70D and duplicate the entry and change to 80D.

#32 Updated by Roman Lebedev over 3 years ago

  • Subject changed from Canon 80D to Canon 80D - m/s-RAW support

Right, forgot.

#33 Updated by Roman Lebedev over 3 years ago

  • % Done changed from 100 to 20
  • Status changed from Fixed to Incomplete

#34 Updated by Stefan Löffler over 3 years ago

I recently proposed a patch for the rawspeed library (https://github.com/klauspost/rawspeed/pull/161) that fixed the mRaw display issue for me (though I'm not sure if it complies with all coding principles of rawspeed or breaks support for other cameras - it should be fine, but I have not tested it).

#35 Updated by Roman Lebedev over 3 years ago

Since our bundled rawspeed is mostly being developed, and then the changes upstreamed after some time, you can just PR it to us :)

#36 Updated by Stefan Löffler over 3 years ago

Done (https://github.com/darktable-org/darktable/pull/1294) with a slightly improved code.

#37 Updated by Stefan Löffler over 3 years ago

  • % Done changed from 20 to 100
  • Status changed from Incomplete to Fixed

#38 Updated by Roman Lebedev about 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top