Project

General

Profile

Camera Support #10996

Rawspeed: PENTAX K-5 probably has wrong black level

Added by Roman Lebedev over 3 years ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
04/17/2016
Due date:
% Done:

0%

Affected Version:
git development version

Description

Black level is 512, yet calculated sep_blacs are ~64
With the samples from #10995


Related issues

Copied from darktable - Bug #10995: Exposure module : automatic mode does not help deflickering Fixed 04/17/2016

Associated revisions

Revision c1be2cc2
Added by Roman Lebedev over 3 years ago

Exposure iop: compute_correction(): use sep blacks. Refs #10995, Refs #10996.

For some cameras rawspeed provides some really bogus value
for black level, e.g for PENTAX K-5 it is reported as 512,
while sep blacks are calculated at ~67.

For deflickering it is really unfortunate.

Since this is the only place where we use black level,
and everywhere else we use sep blacks, let's just
average those. If sep blacks are wrong - we will notice.

Note: this technically does change the output,
but only in cases where rawspeed is lying.

Revision c3dfcbb2
Added by Roman Lebedev about 3 years ago

Exposure iop: compute_correction(): use sep blacks. Refs #10995, Refs #10996.

For some cameras rawspeed provides some really bogus value
for black level, e.g for PENTAX K-5 it is reported as 512,
while sep blacks are calculated at ~67.

For deflickering it is really unfortunate.

Since this is the only place where we use black level,
and everywhere else we use sep blacks, let's just
average those. If sep blacks are wrong - we will notice.

Note: this technically does change the output,
but only in cases where rawspeed is lying.

(cherry picked from commit c1be2cc2fbfe42d3c6c367be0e19046c5b00bad8)

Revision e9f10d74
Added by Roman Lebedev about 3 years ago

Merge remote-tracking branch 'upstream/master' into lab-io

  • upstream/master: (24 commits)
    Attach Xmp data to EXR files
    No caps for "darktable" in EXR comment
    Get a bugfix for cacorrect from RawTherapee
    Add Slovenian to available languages
    [l10n] Add Slovenian translation
    Fix lock/checkmark icons in prefs
    minor cleanups debug.lua
    Exposure iop: compute_correction(): use sep blacks. Refs #10995, Refs #10996.
    Exposure iop: raw_to_ev(): avoid unsigned underflow :(. Refs #10995
    lua complete rewrite of threading
    lua doc : skip documentation for the knight view
    noiseprofile: Add Canon G15
    Allow line lengths of 115 when formatting
    Fixup of my address in darktable-cli.pod
    [l10n] Swedish update
    Update French translation.
    Update French translation.
    Update French translation of the user manual
    Minor update of doc/usermanual/po/fr.po
    Watermark IOP: gui_update(): unselect all 9 alignment toggles
    ...

History

#1 Updated by Roman Lebedev over 3 years ago

  • Copied from Bug #10995: Exposure module : automatic mode does not help deflickering added

Also available in: Atom PDF