Project

General

Profile

Bug #10976

GTK 3.20 Theme

Added by Max Krapiuka almost 4 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
General
Target version:
Start date:
04/03/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0.3
System:
other GNU/Linux
bitness:
64-bit
hardware architecture:
amd64/x86

Description

It is necessary to adapt the theme for the GTK 3.20
See my screen from Gnome 3.20

Снимок экрана от 2016-04-03 00-40-24.png (725 KB) Снимок экрана от 2016-04-03 00-40-24.png Max Krapiuka, 04/03/2016 12:40 AM
darktable.css (9.83 KB) darktable.css CSS for Gtk+ 3.20 Pascal Obry, 04/17/2016 09:03 PM
darktable.css (9.77 KB) darktable.css Pascal Obry, 04/17/2016 10:06 PM
darktable.css (9.99 KB) darktable.css Gtk 3.20 WIP CSS Pascal Obry, 04/21/2016 04:06 PM
darktable.css (10.1 KB) darktable.css Pascal Obry, 04/21/2016 08:36 PM
darktable.css (10.2 KB) darktable.css Pascal Obry, 04/23/2016 09:40 AM
20160530_113242.png (60.9 KB) 20160530_113242.png Sven Greiner, 05/30/2016 12:39 PM
20160530_113527.png (10.1 KB) 20160530_113527.png Sven Greiner, 05/30/2016 12:39 PM
20160530_113649.png (60.6 KB) 20160530_113649.png Sven Greiner, 05/30/2016 12:39 PM
20160530_113826.png (26.7 KB) 20160530_113826.png Sven Greiner, 05/30/2016 12:40 PM
20160530_114118.png (25.8 KB) 20160530_114118.png Sven Greiner, 05/30/2016 12:41 PM

Related issues

Has duplicate darktable - Bug #10988: GTK 3.20 compatibility problemsDuplicate04/10/2016

Has duplicate darktable - Bug #10990: Button/icon sizes too large with GTK 3.20Duplicate04/10/2016

Has duplicate darktable - Bug #10993: GNOME 3.20 breaks git build (deprecated features)Duplicate04/12/2016

Has duplicate darktable - Bug #11249: Display scaling on OS X b0rked in current masterDuplicate10/20/2016

History

#1 Updated by Roman Lebedev almost 4 years ago

#2 Updated by Roman Lebedev almost 4 years ago

  • Status changed from New to Duplicate

Repeatedly opening the same bugreports with the same subject and context will not make anything happen any faster.

#3 Updated by Max Krapiuka almost 4 years ago

Roman Lebedev wrote:

Repeatedly opening the same bugreports with the same subject and context will not make anything happen any faster.

Just I thought I opened the wrong bug to a website and not for darktable.

#4 Updated by Roman Lebedev almost 4 years ago

#5 Updated by Roman Lebedev almost 4 years ago

  • Has duplicate Bug #10988: GTK 3.20 compatibility problems added

#6 Updated by Roman Lebedev almost 4 years ago

  • Status changed from Duplicate to New

Max Krapiuka wrote:

Roman Lebedev wrote:

Repeatedly opening the same bugreports with the same subject and context will not make anything happen any faster.

Just I thought I opened the wrong bug to a website and not for darktable.

Uh, right, sorry.

#7 Updated by Roman Lebedev almost 4 years ago

  • Has duplicate Bug #10990: Button/icon sizes too large with GTK 3.20 added

#8 Updated by Roman Lebedev almost 4 years ago

  • Has duplicate Bug #10993: GNOME 3.20 breaks git build (deprecated features) added

#9 Updated by Sven Greiner almost 4 years ago

Can you please increase the priority of this issue? Darktable is almost unusable on Arch Linux with gtk 3.20. Darktable was ported to gtk3 just a few months ago, had some minor issues with it, but showed some improvements. Now it is completely broken.

#10 Updated by Francisco Cribari almost 4 years ago

I second that request. My two notebooks now run Arch and I have been unable to use Darktable to process my RAW files.

Sven Greiner wrote:

Can you please increase the priority of this issue? Darktable is almost unusable on Arch Linux with gtk 3.20. Darktable was ported to gtk3 just a few months ago, had some minor issues with it, but showed some improvements. Now it is completely broken.

#11 Updated by Roman Lebedev almost 4 years ago

(the following is author's personal opinion)

I feel like saying this:
Gtk considers this breakage to be a feature.
Why should not we consider it a feature also, but fix it?
Go complain to gtk.

#12 Updated by Pascal Obry almost 4 years ago

Strange issue. I had a quick look and possibly a Gtk 3.20 bug. The fact is that on the CSS * rule is taken into account, all others (that this 95% of the darktable.css) rules have no effect! If someone has a slight idea of what is going on...

#13 Updated by Pascal Obry almost 4 years ago

Ok, here is a Work In Progress version of darktable.css. I do intend to propose a patch for this at some point. I just post it here as a convenience if like me you have to work on some pictures.

Just put this file into ~/.config/darktable

Feel free to report issues there is probably plenty left...

#14 Updated by Pascal Obry almost 4 years ago

A version with the active tab visible.

#15 Updated by Francisco Cribari almost 4 years ago

Thank you!!! I gave it a try. So far so good.

Pascal Obry wrote:

A version with the active tab visible.

#16 Updated by Pascal Obry almost 4 years ago

Another version with progress bar and notebook tab fixed.

#17 Updated by Pascal Obry almost 4 years ago

And yet another version, fixes the colorswatch and the notebook take over and selection.

#18 Updated by Sven Greiner almost 4 years ago

Pascal Obry wrote:

Strange issue. I had a quick look and possibly a Gtk 3.20 bug. The fact is that on the CSS * rule is taken into account, all others (that this 95% of the darktable.css) rules have no effect! If someone has a slight idea of what is going on...

gtk 3.20 changed the way elements are addressed. I don't know if you mean this or something else.

It was announced already five months ago: https://blogs.gnome.org/mclasen/2015/11/20/a-gtk-update/

#19 Updated by Pascal Obry almost 4 years ago

Sven Greiner wrote:

Pascal Obry wrote:

Strange issue. I had a quick look and possibly a Gtk 3.20 bug. The fact is that on the CSS * rule is taken into account, all others (that this 95% of the darktable.css) rules have no effect! If someone has a slight idea of what is going on...

gtk 3.20 changed the way elements are addressed. I don't know if you mean this or something else.

It was announced already five months ago: https://blogs.gnome.org/mclasen/2015/11/20/a-gtk-update/

Sure :) But since the message you quoted I have proposed 4 CSS for darktable! The latest and greatest should be almost 100% ok.

#20 Updated by Johannes Hanika almost 4 years ago

hi,

did you notice the gtk-3.20: prefixed patches in the lab-io branch in the main repo?

https://github.com/darktable-org/darktable/blob/lab-io/data/darktable.css.in

i think we should probably try and merge efforts. and come up with a strategy how to ship both <3.20 and >=3.20 css (there have been some code changes to #ifdef, too).

-jo

#21 Updated by Pascal Obry almost 4 years ago

Hi Johannes,

did you notice the gtk-3.20: prefixed patches in the lab-io branch in the main repo?

https://github.com/darktable-org/darktable/blob/lab-io/data/darktable.css.in

Yes I did, you started after me :) I had a quick look yesterday night and I think my current version looks better (almost as good as the previous version). What is the plan for the lab-io branch? Is the merge planned soon or not?

i think we should probably try and merge efforts. and come up with a strategy how to ship both <3.20 and >=3.20 css (there have been some code changes to #ifdef, too).

Right that's the most annoying part. And if a #ifdef would work for people building on their computer would it work for the different binary packages?

#22 Updated by Johannes Hanika almost 4 years ago

Pascal Obry wrote:

Hi Johannes,

did you notice the gtk-3.20: prefixed patches in the lab-io branch in the main repo?

https://github.com/darktable-org/darktable/blob/lab-io/data/darktable.css.in

Yes I did, you started after me :)

as far as i'm concerned redmine is a good place to make me ignore things forever :)

I had a quick look yesterday night and I think my current version looks better (almost as good as the previous version). What is the plan for the lab-io branch? Is the merge planned soon or not?

i also have a couple of px -> pt conversions for highdpi displays, so unfortunately i think we really need to compare every line :/

lab-io has many things that could just be merged, and one more subtle thing to carefully look at (propagate negative numbers in the pipe for a bit, for better denoising etc).

i think we should probably try and merge efforts. and come up with a strategy how to ship both <3.20 and >=3.20 css (there have been some code changes to #ifdef, too).

Right that's the most annoying part. And if a #ifdef would work for people building on their computer would it work for the different binary packages?

would not be binary compatible, no. the old ifdef might work with new gtk, but definitely not the other way around.

#23 Updated by Jan Ypma almost 4 years ago

Has anyone been able to increase the icon button size on HiDPI screens? This might be a separate issue, but all the icon buttons snap to exactly 18px in the current CSS, ignoring DPI. I can make them bigger with

button { min-width: 2em; }

but that doesn't increase the size of the spacers between buttons, messing up the layout a bit.

Let me know if I should put this in a separate issue.

#24 Updated by Francisco Cribari almost 4 years ago

Pascal: lighttable -> styles: I'm unable to select a style by clicking on its name.

Pascal Obry wrote:

And yet another version, fixes the colorswatch and the notebook take over and selection.

#25 Updated by Pascal Obry almost 4 years ago

I do not see the line selected but when I double click on it I can apply the style. Same for tags dialog BTW. Will fix.

#26 Updated by Pascal Obry almost 4 years ago

A new version with the fix for style, collection and tags selection.

#27 Updated by Johannes Hanika almost 4 years ago

Pascal Obry wrote:

A new version with the fix for style, collection and tags selection.

okay, i'm trying to merge this into git now, please stop posting new files in the meantime :)

#28 Updated by Pascal Obry almost 4 years ago

Sure! Thanks for merging and especially checking that it works in HiDPI mode which is something I can't do on my side!

#29 Updated by Johannes Hanika almost 4 years ago

Johannes Hanika wrote:

okay, i'm trying to merge this into git now, please stop posting new files in the meantime :)

this is now done (a9ce4fc), the git version contained a few other things on top of yours, some were near identical, and some i didn't understand..

in particular the global min-width setting did not work for me (made combobox arrows pretty much disappear).

maybe you can double check if things still work for you as expected?

#30 Updated by Pascal Obry almost 4 years ago

Ok I have double checked. Almost correct on my side. I have fixed the progress bar (the progress was not visibile) and the entries where a huge margin was present.

I still have an issue on my side where I do not see the scrollbars. I'll try to fix...

I also found that the checkbox for copy partial dialog are not visible.

#31 Updated by Roman Lebedev almost 4 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

As of now, git master and 2.0.x are both good with 3.18 and 3.20.
Some theme tuning might be helpful still, maybe.

#32 Updated by Sven Greiner over 3 years ago

Some remaining issues with the gtk 3.20 theme in 2.0.4:

  • Missing scrollbars e.g. in preferences
  • Missing entry and checkbox border
  • No buttons border or too low contrast
  • Thick separator in sidebars
  • No button padding
  • Blurred font in lighttable (maybe gray shadow or outline)
  • Strange thick scrollbar in sidebars, collapse "bar" has strange marker at two-thirds
  • Missing margin between label and slider

#34 Updated by Roman Lebedev over 3 years ago

  • Has duplicate Bug #11249: Display scaling on OS X b0rked in current master added

#35 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top