Project

General

Profile

Bug #10946

compilation error... including fix

Added by Markus Kanet about 4 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Buildsystem
Target version:
Start date:
03/11/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
other GNU/Linux
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi...
when compiling latest git/master i get the following build error:

[ 63%] Building CXX object src/iop/CMakeFiles/demosaic.dir/amaze_demosaic_RT.cc.o
In file included from /tmp/darktable-org-darktable-8f290db/src/common/opencl.h:39:0,
                 from /tmp/darktable-org-darktable-8f290db/src/develop/imageop.h:37,
                 from /tmp/darktable-org-darktable-8f290db/src/iop/amaze_demosaic_RT.cc:22:
/tmp/darktable-org-darktable-8f290db/src/control/conf.h: In function 'void dt_conf_set_int64(const char*, int64_t)':
/tmp/darktable-org-darktable-8f290db/src/control/conf.h:102:35: error: expected ')' before 'PRId64'
   char *str = g_strdup_printf("%" PRId64, val);
                                   ^
/tmp/darktable-org-darktable-8f290db/src/control/conf.h:102:46: warning: spurious trailing '%' in format [-Wformat=]
   char *str = g_strdup_printf("%" PRId64, val);
                                              ^
/tmp/darktable-org-darktable-8f290db/src/control/conf.h:102:46: warning: too many arguments for format [-Wformat-extra-args]
make[2]: *** [src/iop/CMakeFiles/demosaic.dir/amaze_demosaic_RT.cc.o] Error 1
make[1]: *** [src/iop/CMakeFiles/demosaic.dir/all] Error 2
make: *** [all] Error 2

I fixed this by adding a #define on top of /src/iop/amaze_demosaic_RT.cc:

diff -U3 -d -r -N darktable-org-darktable-8f290db/src/iop/amaze_demosaic_RT.cc darktable-org.fixed/src/iop/amaze_demosaic_RT.cc
--- darktable-org-darktable-8f290db/src/iop/amaze_demosaic_RT.cc    2016-03-10 17:15:03.000000000 +0100
+++ darktable-org.fixed/src/iop/amaze_demosaic_RT.cc    2016-03-11 06:39:13.385787772 +0100
@@ -16,6 +16,8 @@
     along with darktable.  If not, see <http://www.gnu.org/licenses/>.
 */

+#define __STDC_FORMAT_MACROS
+
 #include <algorithm>

 extern "C" {

This bug looks similar to http://redmine.darktable.org/issues/10111

Associated revisions

Revision f406e5b5 (diff)
Added by Tobias Ellinghaus about 4 years ago

Fix #10946: Fix compilation

History

#1 Updated by Tobias Ellinghaus about 4 years ago

What compiler are you using?

#2 Updated by Tobias Ellinghaus about 4 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

#3 Updated by Roman Lebedev over 3 years ago

  • Target version changed from Candidate for next patch release to 2.2.0

Also available in: Atom PDF

Go to top