Project

General

Profile

Bug #10945

liquify tool crashes when drawing controls far outside the picture (backtraces attached)

Added by Matthieu Moy almost 4 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
03/07/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
Debian
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi,

While testing the liquify tool, I found several ways to trigger a crash.

In both case, start with zoom = small.

Crash 1 : Using the "point" tool. Make an insanely large point (diameter bigger than the picture). Backtrace attached.

Crash 2 : Using the "draw lines" tool. Drag a line far away from the picture, around the picture. Backtrace attached too.

In both cases, I get crashes more often than not, but it's not 100% reproducible.

(This was discussed in the comments of bug #10939 but let's keep a proper track of it with an open bug)

darktable_bt_1XLPDY.txt (167 Bytes) darktable_bt_1XLPDY.txt Crash using the "point" tool and very large diameter. Matthieu Moy, 03/07/2016 09:10 PM
darktable_bt_7RIVDY.txt (133 KB) darktable_bt_7RIVDY.txt Crash using the "draw lines" tool and lines around the picture Matthieu Moy, 03/07/2016 09:15 PM
liquify.jpg (33.9 KB) liquify.jpg Pascal Obry, 03/07/2016 10:15 PM

Associated revisions

Revision d172155d (diff)
Added by Roman Lebedev almost 4 years ago

Liquify iop: modify_roi_in(): do not use piece->pipe->*. Fixes #10945

History

#1 Updated by Roman Lebedev almost 4 years ago

  • % Done changed from 0 to 10
  • Status changed from New to Confirmed

#2 Updated by Pascal Obry almost 4 years ago

Anything special about your picture? What I did is:

- use the RAW (clean history)
- move to zoom small
- take the line tool and draw around the picture
- take a large circle far bigger than the picture

no crash on my side :( Am I lucky or I'm missing something to reproduce?

See attached picture (circle test not on the picture).

#3 Updated by Roman Lebedev almost 4 years ago

  • % Done changed from 10 to 100
  • Status changed from Confirmed to Fixed

#4 Updated by Matthieu Moy almost 4 years ago

Wow, you are too quick!

I confirm: I can't get liquify to crash anymore (even torturing it!). Thanks!

#5 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top