Project

General

Profile

Bug #10928

Spot removal tool has an offset at target

Added by Steve Crossley about 4 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
02/21/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0.1
System:
other GNU/Linux
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi,
Trying to remove some snowflakes using the spot removal tool I noticed that the area translated by the tool is offset from the target displayed. Screen-shot attached to show example.

If it makes a difference, I'm using Linux Mint with the Cinnamon desktop, an NVidia 9800 and a 4k monitor.

Thanks
Steve

P.S. Great software which just keeps getting better, thanks.

Screenshot from 2016-02-21 10_16_52.png (1.23 MB) Screenshot from 2016-02-21 10_16_52.png Steve Crossley, 02/21/2016 04:19 AM
IMG_4444.CR2.xmp (5.83 KB) IMG_4444.CR2.xmp Steve Crossley, 02/22/2016 12:05 PM
IMG_4441.CR2.xmp (6.75 KB) IMG_4441.CR2.xmp Steve Crossley, 02/22/2016 12:22 PM
dt-2.0.5.log (2.64 KB) dt-2.0.5.log Log generated with darktable-cli 2.0.5 Rafa G., 08/05/2016 01:04 AM
dt-2.0.4.log (2.64 KB) dt-2.0.4.log Log generated with darktable-cli 2.0.4 Rafa G., 08/05/2016 01:04 AM

Related issues

Has duplicate darktable - Bug #10963: issue with mask and crop&rotate Duplicate03/26/2016

Associated revisions

Revision de35b592 (diff)
Added by Aldric Renaudin about 4 years ago

clipping: workaround for roi int / float rounding

as dt_iop_roi_t contain int values and not floats, we can have some rounding errors
this is especially visible for masks, as they use preview pipe with low resolutions
Fixes bug #10928

Revision 2ff4bd5c
Added by Johannes Hanika over 3 years ago

Merge pull request #1161 from AlicVB/clip_roi_int

clipping: workaround for roi int / float rounding fix #10928

History

#1 Updated by Aldric Renaudin about 4 years ago

can you please share an xmp file showing this pb ? I'm not able to reproduce here...

#2 Updated by Roman Lebedev about 4 years ago

  • Subject changed from Spot removal toll has an offset at target to Spot removal tool has an offset at target

#3 Updated by Steve Crossley about 4 years ago

xmp attached as requested. I tried to reproduce the bug in another file first but it didn't occur. That first file had fewer steps in its history. It seems to only occur in files that I have modified in other ways before getting to the spot removal. I'll see if I can narrow it down.

#4 Updated by Steve Crossley about 4 years ago

The problem seems to come up using any drawn mask when a crop and rotate is enabled, not just spot removal. The problem goes away if crop and rotate is turned off.

#5 Updated by jam bam about 4 years ago

I can confirm this behavior. When a crop+rotate is activated, there's an offset on the masks. Workaround is to disable crop+rotate IOP, make adjustments as needed to masks, then reactivate crop+rotate.

#6 Updated by Aldric Renaudin about 4 years ago

Duplicated by #10963 : issue with mask and crop&rotate

#7 Updated by Aldric Renaudin about 4 years ago

FYI, there's a pending pull request which mostly fix the pb : PR #1161

#8 Updated by Roman Lebedev about 4 years ago

  • Has duplicate Bug #10963: issue with mask and crop&rotate added

#9 Updated by Rafa G. over 3 years ago

Any news on this issue, about when the PR will merged?

Thanks!

#10 Updated by Rafa G. over 3 years ago

I was speaking with Houz via IRC and he recommended me to execute darktable-cli for the logs files.
Not too much difference between version (2.0.5 a little bit faster than 2.0.4)

I attach the new log files for dt-2.0.4 and dt-2.0.5

Ignore this comment. It was for another issue.

If some admin reads it, could you delete it? Thanks

#11 Updated by Johannes Hanika over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

#12 Updated by Roman Lebedev over 3 years ago

  • Target version set to 2.2.0

Also available in: Atom PDF

Go to top